Merge lp:~cjcurran/indicator-sound/pulse-proper-error-handling into lp:~indicator-applet-developers/indicator-sound/trunk_3
Proposed by
Conor Curran
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 206 | ||||||||
Proposed branch: | lp:~cjcurran/indicator-sound/pulse-proper-error-handling | ||||||||
Merge into: | lp:~indicator-applet-developers/indicator-sound/trunk_3 | ||||||||
Diff against target: |
107 lines (+21/-16) 1 file modified
src/pulseaudio-mgr.c (+21/-16) |
||||||||
To merge this branch: | bzr merge lp:~cjcurran/indicator-sound/pulse-proper-error-handling | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email: mp+51530@code.launchpad.net |
Description of the change
I wasn't properly handling an edge case concerning pulse server callback communication whereby the eol is not positive (i.e. its not the end of a sequence of callbacks) but the pulse pointer is null. According to the docs this reflects some sort of error. It can be seen to be triggered when you remove a sound device (usb headset or whatever) while a Voip app is open. Fixes the bug attached and I suspect some of the other weird crashes reported in recent weeks.
To post a comment you must log in.
Looks good to me