Merge lp:~cjcurran/indicator-sound/odd-determine-key-crash into lp:indicator-sound/fourth

Proposed by Conor Curran
Status: Merged
Merged at revision: 279
Proposed branch: lp:~cjcurran/indicator-sound/odd-determine-key-crash
Merge into: lp:indicator-sound/fourth
Diff against target: 33 lines (+8/-3)
2 files modified
.bzrignore (+6/-0)
src/music-player-bridge.vala (+2/-3)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/odd-determine-key-crash
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+80481@code.launchpad.net

Description of the change

fixes attached bug

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2011-01-11 10:42:06 +0000
3+++ .bzrignore 2011-10-26 16:45:35 +0000
4@@ -82,3 +82,9 @@
5 tests/libmockpulse.la
6 tests/libmockpulse_la-mockpulse.lo
7 src/libsoundmenu_la-gen-sound-service.xml.lo
8+src/libsoundmenu_la-mute-widget.lo
9+src/libsoundmenu_la-sound-state-manager.lo
10+src/libsoundmenu_la-sound-state.lo
11+src/libsoundmenu_la-voip-input-widget.lo
12+src/specific-items-manager.c
13+src/stamp-marshal
14
15=== modified file 'src/music-player-bridge.vala'
16--- src/music-player-bridge.vala 2011-09-09 17:47:00 +0000
17+++ src/music-player-bridge.vala 2011-10-26 16:45:35 +0000
18@@ -229,14 +229,13 @@
19 {
20 var result = desktop_or_interface;
21 var tokens = desktop_or_interface.split( "." );
22- if ( tokens.length > 1 ){
23+ if (tokens != null && tokens.length > 1){
24 result = tokens[tokens.length - 1];
25 }
26 var temp = result.split("-");
27- if (temp.length > 1){
28+ if (temp != null && temp.length > 1){
29 result = temp[0];
30 }
31- debug("determine key result = %s", result);
32 return result;
33 }
34

Subscribers

People subscribed via source and target branches