Merge lp:~cjcurran/indicator-sound/missing-nonmono-icon into lp:indicator-sound/sound-menu-v2

Proposed by Conor Curran
Status: Merged
Merged at revision: 134
Proposed branch: lp:~cjcurran/indicator-sound/missing-nonmono-icon
Merge into: lp:indicator-sound/sound-menu-v2
Diff against target: 210 lines (+143/-1)
9 files modified
configure.ac (+5/-0)
data/Makefile.am (+2/-0)
data/icons/16x16/Makefile.am (+1/-0)
data/icons/16x16/status/Makefile.am (+8/-0)
data/icons/Makefile.am (+15/-0)
data/icons/scalable/Makefile.am (+1/-0)
data/icons/scalable/status/Makefile.am (+8/-0)
data/icons/scalable/status/sound-icon.svg (+102/-0)
src/title-widget.c (+1/-1)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/missing-nonmono-icon
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+35302@code.launchpad.net

This proposal supersedes a proposal from 2010-09-13.

Description of the change

fixes the bug attached

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2010-09-10 13:21:38 +0000
3+++ configure.ac 2010-09-13 16:17:52 +0000
4@@ -135,6 +135,11 @@
5 Makefile
6 src/Makefile
7 data/Makefile
8+data/icons/Makefile
9+data/icons/16x16/Makefile
10+data/icons/16x16/status/Makefile
11+data/icons/scalable/Makefile
12+data/icons/scalable/status/Makefile
13 tests/Makefile
14 po/Makefile.in
15 ])
16
17=== modified file 'data/Makefile.am'
18--- data/Makefile.am 2010-07-07 14:08:34 +0000
19+++ data/Makefile.am 2010-09-13 16:17:52 +0000
20@@ -1,3 +1,5 @@
21+SUBDIRS = icons
22+
23 dbus_servicesdir = $(DBUSSERVICEDIR)
24 service_in_files = indicator-sound.service.in
25 dbus_services_DATA = $(service_in_files:.service.in=.service)
26
27=== added directory 'data/icons'
28=== added directory 'data/icons/16x16'
29=== added file 'data/icons/16x16/Makefile.am'
30--- data/icons/16x16/Makefile.am 1970-01-01 00:00:00 +0000
31+++ data/icons/16x16/Makefile.am 2010-09-13 16:17:52 +0000
32@@ -0,0 +1,1 @@
33+SUBDIRS = status
34
35=== added directory 'data/icons/16x16/status'
36=== added file 'data/icons/16x16/status/Makefile.am'
37--- data/icons/16x16/status/Makefile.am 1970-01-01 00:00:00 +0000
38+++ data/icons/16x16/status/Makefile.am 2010-09-13 16:17:52 +0000
39@@ -0,0 +1,8 @@
40+
41+iconsdir = $(INDICATORICONSDIR)/hicolor/16x16/status
42+
43+icons_DATA = \
44+ sound-icon.png
45+
46+EXTRA_DIST = $(icons_DATA)
47+
48
49=== added file 'data/icons/16x16/status/sound-icon.png'
50Binary files data/icons/16x16/status/sound-icon.png 1970-01-01 00:00:00 +0000 and data/icons/16x16/status/sound-icon.png 2010-09-13 16:17:52 +0000 differ
51=== added file 'data/icons/Makefile.am'
52--- data/icons/Makefile.am 1970-01-01 00:00:00 +0000
53+++ data/icons/Makefile.am 2010-09-13 16:17:52 +0000
54@@ -0,0 +1,15 @@
55+SUBDIRS = scalable 16x16
56+
57+gtk_update_icon_cache = gtk-update-icon-cache -f -t $(pkgdatadir)/icons/hicolor
58+
59+install-data-hook: update-icon-cache
60+uninstall-hook: update-icon-cache
61+update-icon-cache:
62+ @-if test -z "$(DESTDIR)"; then \
63+ echo "Updating Gtk icon cache."; \
64+ $(gtk_update_icon_cache); \
65+ else \
66+ echo "*** Icon cache not updated. After (un)install, run this:"; \
67+ echo "*** $(gtk_update_icon_cache)"; \
68+ fi
69+
70
71=== added directory 'data/icons/scalable'
72=== added file 'data/icons/scalable/Makefile.am'
73--- data/icons/scalable/Makefile.am 1970-01-01 00:00:00 +0000
74+++ data/icons/scalable/Makefile.am 2010-09-13 16:17:52 +0000
75@@ -0,0 +1,1 @@
76+SUBDIRS = status
77
78=== added directory 'data/icons/scalable/status'
79=== added file 'data/icons/scalable/status/Makefile.am'
80--- data/icons/scalable/status/Makefile.am 1970-01-01 00:00:00 +0000
81+++ data/icons/scalable/status/Makefile.am 2010-09-13 16:17:52 +0000
82@@ -0,0 +1,8 @@
83+
84+iconsdir = $(INDICATORICONSDIR)/hicolor/scalable/status
85+
86+icons_DATA = \
87+ sound-icon.svg
88+
89+EXTRA_DIST = $(icons_DATA)
90+
91
92=== added file 'data/icons/scalable/status/sound-icon.svg'
93--- data/icons/scalable/status/sound-icon.svg 1970-01-01 00:00:00 +0000
94+++ data/icons/scalable/status/sound-icon.svg 2010-09-13 16:17:52 +0000
95@@ -0,0 +1,102 @@
96+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
97+<!-- Created with Inkscape (http://www.inkscape.org/) -->
98+
99+<svg
100+ xmlns:svg="http://www.w3.org/2000/svg"
101+ xmlns="http://www.w3.org/2000/svg"
102+ xmlns:xlink="http://www.w3.org/1999/xlink"
103+ version="1.1"
104+ width="16"
105+ height="16"
106+ id="svg3809">
107+ <defs
108+ id="defs3811">
109+ <linearGradient
110+ x1="28.739122"
111+ y1="144.11652"
112+ x2="26.256771"
113+ y2="125.39074"
114+ id="linearGradient2974"
115+ xlink:href="#linearGradient2372"
116+ gradientUnits="userSpaceOnUse"
117+ gradientTransform="matrix(0.2545239,0,0,0.12875595,6.0849926,-15.173532)" />
118+ <linearGradient
119+ id="linearGradient2372">
120+ <stop
121+ id="stop2374"
122+ style="stop-color:#ffffff;stop-opacity:1"
123+ offset="0" />
124+ <stop
125+ id="stop2376"
126+ style="stop-color:#ffffff;stop-opacity:0.37931034"
127+ offset="1" />
128+ </linearGradient>
129+ <linearGradient
130+ x1="28.739122"
131+ y1="144.11652"
132+ x2="25.400293"
133+ y2="119.86452"
134+ id="linearGradient2977"
135+ xlink:href="#linearGradient2372"
136+ gradientUnits="userSpaceOnUse"
137+ gradientTransform="matrix(0.12649532,0,0,0.12875595,2.1139996,-14.056928)" />
138+ <radialGradient
139+ cx="17.058823"
140+ cy="41.058823"
141+ r="5.7384715"
142+ fx="15.970393"
143+ fy="39.105911"
144+ id="radialGradient2980"
145+ xlink:href="#linearGradient7067-814-120-245"
146+ gradientUnits="userSpaceOnUse"
147+ gradientTransform="matrix(0.3698584,-0.06212313,0,0.35879901,4.6705097,-1.5148309)" />
148+ <linearGradient
149+ id="linearGradient7067-814-120-245">
150+ <stop
151+ id="stop3877"
152+ style="stop-color:#aaaaaa;stop-opacity:1"
153+ offset="0" />
154+ <stop
155+ id="stop3879"
156+ style="stop-color:#4d4d4d;stop-opacity:1"
157+ offset="1" />
158+ </linearGradient>
159+ <radialGradient
160+ cx="17.058823"
161+ cy="41.058823"
162+ r="5.7384715"
163+ fx="15.544384"
164+ fy="39.027378"
165+ id="radialGradient2983"
166+ xlink:href="#linearGradient7067-814-120-245"
167+ gradientUnits="userSpaceOnUse"
168+ gradientTransform="matrix(0.37667571,-0.06311262,0,0.36451394,-2.446246,-0.69065449)" />
169+ </defs>
170+ <g
171+ id="layer1">
172+ <path
173+ d="M 12.887143,11.242639 12.520463,8.2875931"
174+ id="path2931"
175+ style="fill:none;stroke:none" />
176+ <path
177+ d="M 12.862181,0.50107998 C 10.505078,0.88091513 7.3505507,1.2719259 5,1.6729744 4.3775618,1.9766657 4.5174948,2.758676 4.4899572,3.3260967 c 0,2.5319424 0,5.0638848 0,7.5958273 -1.3117262,-0.246608 -2.9113558,0.837273 -2.9807337,2.553424 -0.1132522,1.068438 0.8342068,1.998453 1.8644819,2.023461 1.844664,0.04478 3.1062853,-1.179076 3.1262946,-2.726857 -0.020145,-2.599408 0.00566,-5.1998384 0,-7.7996448 0.2855763,-0.02115 4.61103,-0.8465037 5,-0.901457 0,1.9471472 0,3.8942945 0,5.8414417 -1.146387,-0.2746364 -2.6118971,0.4787211 -2.9752697,2.0172541 -0.15337,0.862385 0.1364969,1.944831 1.0115464,2.309984 1.7082373,0.784936 4.0532683,-0.805037 3.9579313,-2.671065 -0.02646,-3.4661732 0.02169,-6.933764 0,-10.4003066 -0.04486,-0.32575865 -0.265607,-0.69059252 -0.632027,-0.66707842 z"
178+ id="path4031"
179+ style="fill:#4d4d4d;fill-opacity:1;stroke:#333333;stroke-width:1;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none" />
180+ <path
181+ d="m 5.9735639,12.865117 a 1.7166647,2.0994822 57.095252 0 1 -3.9883314,0.66825 1.7166647,2.0994822 57.095252 0 1 3.9883314,-0.66825 z"
182+ id="path2937"
183+ style="fill:url(#radialGradient2983);fill-opacity:1;stroke:none" />
184+ <path
185+ d="M 12.937933,11.82841 A 1.6885125,2.0629959 56.769744 0 1 9.0217849,12.486184 1.6885125,2.0629959 56.769744 1 1 12.937933,11.82841 z"
186+ id="path2941"
187+ style="fill:url(#radialGradient2980);fill-opacity:1;stroke:none" />
188+ <path
189+ d="M 5.0536869,11.476373 5,2.7939369 c 0,0 0.05877,-0.6637646 0.4947159,-0.6657879 0.1546126,-0.027048 6.9317151,-1.15654738 6.9317151,-1.15654738 0,0 0.132983,0.70947368 -6.0694897,1.62965478 -0.516931,0.077068 -0.76544,0.068481 -0.7627163,0.5583664 0.00735,1.3216244 -0.030358,3.795953 -0.030358,8.6082552 0,0.03443 -0.3254384,-0.243938 -0.5101806,-0.291505 z"
190+ id="path2945"
191+ style="opacity:0.4;fill:url(#linearGradient2977);fill-opacity:1;fill-rule:evenodd;stroke:none" />
192+ <path
193+ d="m 12,10.271349 0.03393,-6.5590211 c 0.357493,-0.0323 0.05489,-0.00519 0.53695,-0.053577 0.0066,1.2251582 2.74e-4,2.2420961 2.74e-4,6.8691941 0,0.03443 -0.199425,-0.209029 -0.571151,-0.256596 z"
194+ id="path2947"
195+ style="opacity:0.4;fill:url(#linearGradient2974);fill-opacity:1;fill-rule:evenodd;stroke:none" />
196+ </g>
197+</svg>
198
199=== modified file 'src/title-widget.c'
200--- src/title-widget.c 2010-09-08 14:51:52 +0000
201+++ src/title-widget.c 2010-09-13 16:17:52 +0000
202@@ -85,7 +85,7 @@
203 gint width, height;
204 gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, &width, &height);
205
206- GtkWidget * icon = gtk_image_new_from_icon_name("sound_icon", GTK_ICON_SIZE_MENU);
207+ GtkWidget * icon = gtk_image_new_from_icon_name("sound-icon", GTK_ICON_SIZE_MENU);
208
209 gtk_widget_set_size_request(icon, width
210 + 5 /* ref triangle is 5x9 pixels */

Subscribers

People subscribed via source and target branches

to all changes: