Merge lp:~cjcurran/indicator-sound/metadata-widget-blank-maverick into lp:indicator-sound/sound-menu-v2

Proposed by Conor Curran
Status: Merged
Approved by: Kalle Valo
Approved revision: 156
Merged at revision: 156
Proposed branch: lp:~cjcurran/indicator-sound/metadata-widget-blank-maverick
Merge into: lp:indicator-sound/sound-menu-v2
Diff against target: 24 lines (+2/-4)
1 file modified
src/player-item.vala (+2/-4)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/metadata-widget-blank-maverick
Reviewer Review Type Date Requested Status
Kalle Valo (community) Approve
Review via email: mp+40621@code.launchpad.net

Description of the change

Fixes slight visual bug whereby on starting media client (like rhythmbox )the metadata widget (the part of the menu which holds the track album art and text) does not appear unless the widget is populated.

To post a comment you must log in.
Revision history for this message
Kalle Valo (kvalo) wrote :

My vala skills are very limited, but looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/player-item.vala'
2--- src/player-item.vala 2010-09-03 19:05:42 +0000
3+++ src/player-item.vala 2010-11-11 13:01:32 +0000
4@@ -87,9 +87,7 @@
5 this.property_set_bool(property, v.get_boolean());
6 }
7 }
8- if(this.property_get_bool(MENUITEM_PROP_VISIBLE) == false){
9- this.property_set_bool(MENUITEM_PROP_VISIBLE, true);
10- }
11+ this.property_set_bool(MENUITEM_PROP_VISIBLE, populated(attributes));
12 }
13
14 public bool populated(HashSet<string> attrs)
15@@ -97,8 +95,8 @@
16 foreach(string prop in attrs){
17 debug("populated ? - prop: %s", prop);
18 int value_int = property_get_int(prop);
19- debug("populated ? - prop %s and value %i", prop, value_int);
20 if(property_get_int(prop) != EMPTY){
21+ debug("populated ? - prop %s and value %i", prop, value_int);
22 return true;
23 }
24 }

Subscribers

People subscribed via source and target branches

to all changes: