Merge lp:~cjcurran/indicator-sound/hover-regression into lp:indicator-sound/sound-menu-v2

Proposed by Conor Curran
Status: Merged
Merged at revision: 153
Proposed branch: lp:~cjcurran/indicator-sound/hover-regression
Merge into: lp:indicator-sound/sound-menu-v2
Diff against target: 103 lines (+17/-18)
1 file modified
src/transport-widget.c (+17/-18)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/hover-regression
Reviewer Review Type Date Requested Status
Kalle Valo (community) Approve
Review via email: mp+40008@code.launchpad.net

Description of the change

Fixes attached bug.

To post a comment you must log in.
Revision history for this message
Kalle Valo (kvalo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/transport-widget.c'
2--- src/transport-widget.c 2010-10-26 21:03:20 +0000
3+++ src/transport-widget.c 2010-11-03 19:23:41 +0000
4@@ -114,7 +114,7 @@
5 gpointer userdata );
6 static void transport_widget_menu_hidden ( GtkWidget *menu,
7 TransportWidget *transport);
8-static void transport_widget_notify ( TransportWidget *item,
9+static void transport_widget_notify ( GObject *item,
10 GParamSpec *pspec,
11 gpointer user_data );
12
13@@ -135,12 +135,12 @@
14
15 g_type_class_add_private (klass, sizeof (TransportWidgetPrivate));
16
17- widget_class->button_press_event = transport_widget_button_press_event;
18- widget_class->button_release_event = transport_widget_button_release_event;
19+ widget_class->button_press_event = transport_widget_button_press_event;
20+ widget_class->button_release_event = transport_widget_button_release_event;
21 widget_class->expose_event = transport_widget_expose;
22
23 gobject_class->dispose = transport_widget_dispose;
24- gobject_class->finalize = transport_widget_finalize;
25+ gobject_class->finalize = transport_widget_finalize;
26 }
27
28 static void
29@@ -158,9 +158,9 @@
30 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(5), 1);
31 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(60), 2);
32 previous_list = g_list_insert(previous_list, GINT_TO_POINTER(34), 3);
33- g_hash_table_insert(priv->command_coordinates,
34- GINT_TO_POINTER(TRANSPORT_PREVIOUS),
35- previous_list);
36+ g_hash_table_insert(priv->command_coordinates,
37+ GINT_TO_POINTER(TRANSPORT_PREVIOUS),
38+ previous_list);
39
40 GList* play_list = NULL;
41 play_list = g_list_insert(play_list, GINT_TO_POINTER(58), 0);
42@@ -183,10 +183,10 @@
43 next_list);
44
45 gtk_widget_set_size_request(GTK_WIDGET(self), 200, 50);
46- g_signal_connect (G_OBJECT(self),
47- "notify::parent",
48- G_CALLBACK (transport_widget_notify),
49- NULL);
50+ g_signal_connect (G_OBJECT(self),
51+ "notify",
52+ G_CALLBACK (transport_widget_notify),
53+ NULL);
54 }
55
56 static void
57@@ -213,7 +213,7 @@
58 event->area.width, event->area.height);
59
60 cairo_clip(cr);
61- draw (button, cr);
62+ draw (button, cr);
63
64 cairo_destroy (cr);
65 return FALSE;
66@@ -230,16 +230,16 @@
67 }
68
69 static void
70-transport_widget_notify (TransportWidget *item,
71- GParamSpec *pspec,
72- gpointer user_data)
73+transport_widget_notify ( GObject *item,
74+ GParamSpec *pspec,
75+ gpointer user_data )
76 {
77 if (g_strcmp0 (pspec->name, "parent")){
78 GtkWidget *parent = gtk_widget_get_parent (GTK_WIDGET (item));
79 if (parent){
80 g_signal_connect ( parent, "hide",
81 G_CALLBACK (transport_widget_menu_hidden),
82- item);
83+ item );
84 }
85 }
86 }
87@@ -248,7 +248,6 @@
88 transport_widget_menu_hidden ( GtkWidget *menu,
89 TransportWidget *transport)
90 {
91- //g_debug("Transport Widget's menu hidden method called");
92 g_return_if_fail(IS_TRANSPORT_WIDGET(transport));
93 transport_widget_react_to_button_release(transport, TRANSPORT_NADA);
94 }
95@@ -1274,7 +1273,7 @@
96 G_CALLBACK(transport_widget_property_update), self);
97 gint initial_state = dbusmenu_menuitem_property_get_int( twin_item,
98 DBUSMENU_TRANSPORT_MENUITEM_PLAY_STATE );
99- g_debug("TRANSPORT WIDGET - INITIAL UPDATE = %i", initial_state);
100+ //g_debug("TRANSPORT WIDGET - INITIAL UPDATE = %i", initial_state);
101 transport_widget_toggle_play_pause( self,
102 (TransportWidgetState)initial_state);
103 }

Subscribers

People subscribed via source and target branches

to all changes: