The Sound Menu

Merge lp:~cjcurran/indicator-sound/core-usage into lp:indicator-sound/sound-menu-v2

  1. core-usage
  2. Merge into trunk.0.1
Proposed by Conor Curran
Status: Merged
Merged at revision: 143
Proposed branch: lp:~cjcurran/indicator-sound/core-usage
Merge into: lp:indicator-sound/sound-menu-v2
Diff against target: 11 lines (+0/-1)
1 file modified
src/pulse-manager.c (+0/-1)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/core-usage
Reviewer Review Type Date Requested Status
Kalle Valo (community) Approve
Review via email: mp+37304@code.launchpad.net

Description of the change

before, I was kicking off a new connection to pulse if the initial attempt failed even though the reconnect flag was passed.
Fixes many duplicate bugs been reported since early lucid.

To post a comment you must log in.
Revision history for this message
Kalle Valo (kvalo) wrote :

I don't know enough about PulseAudio to really understand this. I assume the Pa connection is started somewhere else.

But the patch itself looks safe.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/pulse-manager.c'
2--- src/pulse-manager.c 2010-09-14 17:21:02 +0000
3+++ src/pulse-manager.c 2010-10-01 19:02:42 +0000
4@@ -534,7 +534,6 @@
5 case PA_CONTEXT_FAILED:
6 g_warning("FAILED to retrieve context - Is PulseAudio Daemon running ?");
7 pa_server_available = FALSE;
8- reconnect_to_pulse();
9 break;
10 case PA_CONTEXT_TERMINATED:
11 /* g_debug("context terminated");*/

Subscribers

People subscribed via source and target branches

to all changes: