The Sound Menu

Merge lp:~cjcurran/indicator-sound/button-title-release into lp:~indicator-applet-developers/indicator-sound/trunk_3

  1. button-title-release
  2. Merge into trunk_3
Proposed by Conor Curran
Status: Merged
Approved by: Ted Gould
Approved revision: 207
Merged at revision: 207
Proposed branch: lp:~cjcurran/indicator-sound/button-title-release
Merge into: lp:~indicator-applet-developers/indicator-sound/trunk_3
Diff against target: 45 lines (+7/-7)
1 file modified
src/title-widget.c (+7/-7)
To merge this branch: bzr merge lp:~cjcurran/indicator-sound/button-title-release
Reviewer Review Type Date Requested Status
Kalle Valo (community) Approve
Review via email: mp+51631@code.launchpad.net

Description of the change

Fixes bug attached. A one liner but needed.

To post a comment you must log in.
Revision history for this message
Kalle Valo (kvalo) wrote :

The fix makes sense to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/title-widget.c'
2--- src/title-widget.c 2011-01-11 15:13:20 +0000
3+++ src/title-widget.c 2011-02-28 21:00:18 +0000
4@@ -44,8 +44,8 @@
5 static void title_widget_finalize (GObject *object);
6
7 // keyevent consumers
8-static gboolean title_widget_button_press_event (GtkWidget *menuitem,
9- GdkEventButton *event);
10+static gboolean title_widget_button_release_event (GtkWidget *menuitem,
11+ GdkEventButton *event);
12
13 // Dbusmenuitem properties update callback
14 static void title_widget_property_update(DbusmenuMenuitem* item, gchar* property,
15@@ -64,7 +64,7 @@
16 GObjectClass *gobject_class = G_OBJECT_CLASS (klass);
17 GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
18
19- widget_class->button_press_event = title_widget_button_press_event;
20+ widget_class->button_release_event = title_widget_button_release_event;
21
22 g_type_class_add_private (klass, sizeof (TitleWidgetPrivate));
23
24@@ -132,8 +132,8 @@
25
26 /* Suppress/consume keyevents */
27 static gboolean
28-title_widget_button_press_event (GtkWidget *menuitem,
29- GdkEventButton *event)
30+title_widget_button_release_event (GtkWidget *menuitem,
31+ GdkEventButton *event)
32 {
33 //g_debug("TitleWidget::menu_press_event");
34 TitleWidgetPrivate * priv = TITLE_WIDGET_GET_PRIVATE(menuitem);
35@@ -147,8 +147,8 @@
36 }
37
38 static void
39-title_widget_property_update(DbusmenuMenuitem* item, gchar* property,
40- GVariant* value, gpointer userdata)
41+title_widget_property_update (DbusmenuMenuitem* item, gchar* property,
42+ GVariant* value, gpointer userdata)
43 {
44 g_return_if_fail (IS_TITLE_WIDGET (userdata));
45 TitleWidget* mitem = TITLE_WIDGET(userdata);

Subscribers

People subscribed via source and target branches