Merge lp:~cjcurran/indicator-sound/058-fixes into lp:~indicator-applet-developers/indicator-sound/trunk_3
Proposed by
Conor Curran
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Kalle Valo | ||||||||
Approved revision: | 192 | ||||||||
Merged at revision: | 119 | ||||||||
Proposed branch: | lp:~cjcurran/indicator-sound/058-fixes | ||||||||
Merge into: | lp:~indicator-applet-developers/indicator-sound/trunk_3 | ||||||||
Diff against target: |
286 lines (+61/-83) 2 files modified
src/indicator-sound.c (+28/-13) src/transport-widget.c (+33/-70) |
||||||||
To merge this branch: | bzr merge lp:~cjcurran/indicator-sound/058-fixes | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kalle Valo (community) | Approve | ||
Review via email:
|
This proposal supersedes a proposal from 2011-01-28.
Description of the change
Fixes both bugs attached
To post a comment you must log in.
Few questions:
o Casts always make suspicious. Why is cast needed for function pointers, eg this one:
DbusmenuClien tTypeHandler) new_volume_ slider_ widget
o "gboolean user_data" is very confusing. Either it should be of type gpointer or, if it's really a boolean, it should have some other name.