Code review comment for lp:~citrix-openstack/nova/xenapi-glance-2

Revision history for this message
Ewan Mellor (ewanmellor) wrote :

The Glance client library is assumed to be installed, just like any other dependency. It is on PyPI, and can be easy_installed.

We _could_ add a flag to point at a source location, but that would be non-standard. Are you sure?

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Sandy Walsh
Sent: 17 January 2011 14:53
To: <email address hidden>
Subject: Re: [Merge] lp:~citrix-openstack/nova/xenapi-glance-2 into lp:nova

Review: Needs Fixing
There should be some means to point to our glance installation for development purposes as a flag.

I had to add this hack to get it going:

swalsh@novadev:~/openstack/xenapi-glance-2$ bzr diff
=== modified file 'bin/nova-combined'
--- bin/nova-combined 2011-01-11 06:47:35 +0000
+++ bin/nova-combined 2011-01-15 19:43:08 +0000
@@ -34,6 +34,10 @@
 if os.path.exists(os.path.join(possible_topdir, 'nova', '__init__.py')):
     sys.path.insert(0, possible_topdir)

+ glance = os.path.normpath(os.path.join(possible_topdir, "..", "glance"))
+ print "added glance path:", glance
+ sys.path.insert(0, glance)
+
 gettext.install('nova', unicode=1)

Now I'm trying to figure out how to get my images in glance so I can try to create an instance. Tips welcome!

--
https://code.launchpad.net/~citrix-openstack/nova/xenapi-glance-2/+merge/45977
Your team Citrix OpenStack development team is subscribed to branch lp:~citrix-openstack/nova/xenapi-glance-2.

« Back to merge proposal