Code review comment for lp:~citrix-openstack/nova/xenapi-glance-2

I think that we've answered all the questions on this review so far:

  o I have requested a review from rconradharris, as per Thierry's request.

  o We will need to refresh this patch as soon as xs-snap-return-image-id-before-snapshot is merged. This will not be a big deal -- we'll just remove a few changes from xenapi-glance-2, in favour of the changes in xs-snap-return-image-id-before-snapshot.

  o We won't hold up this branch because of the I18N issues, but will fix those in a separate branch.

  o We don't feel the need for an abstraction between Nova and Glance, as Glance is already an abstraction across image services.

  o We have a flag that allows people to continue to use nova-objectstore, so we're not adding a hard dependency upon Glance.

  o We are adding a hard dependency upon Glance's client code (glance.client) and we think this is fine because Glance is part of OpenStack, not a third party.

With all these things addressed, please can someone review the actual content of the branch? I'm keen to get an FFE for this, and it will obviously need careful review in order to do that.

Thanks,

Ewan.