Code review comment for lp:~citrix-openstack/nova/xenapi-glance-2

Revision history for this message
Ewan Mellor (ewanmellor) wrote :

> I am not entirely sure what Ewan really meant it with 'heavily reworked', but
> by following a discussion on the mailing list I understand that the extent of
> the work may be related to when glance-auth gets underway in Cactus.

By "heavily reworked" I meant that nova/image/glance.py would be completely rewritten. This code is now in https://code.launchpad.net/~rconradharris/nova/xs-snap-return-image-id-before-snapshot, which is pending merge into trunk.

As soon as xs-snap-return-image-id-before-snapshot is merged, this will conflict with xenapi-glance-2. We will simply need to remove the changes to nova/image/glance.py, and most likely pip-requires too. There will be no additional changes on our part.

« Back to merge proposal