First of all, Congratulations! to you, Edgar, Shweta and all others that have worked on creating this hunk of code. I concur the feelings of Salvatore and Dan and overall it looks well done!
I believe, Salvatore and Dan have done a extensive review and I believe everything looks pretty good. I did have one small comment regarding this merge-prop and "Define Quantum Plugin Interface for Python" blueprint.
At this point, the above referenced blueprint, which is a non vendor implementation specific, generic Quantum plugin, is already implemented and complete.
I was never under the impression the work contained in this merge-prop was specified under "Define Quantum Plugin Interface for Python" blueprint.
I do like the idea of "multi-switch plugin framework" that you guys have implemented as a generic framework for others to leverage, but I would unlink this branch from "Define Quantum Plugin Interface for Python" blueprint.
Reading the README, I believe we should call this a reference implementation of "Multi-switch plugin framework for a Quantum plugin using Cisco platform components" not "A reference implementation of plugin framework for L2 network."
An "reference implementation" is something that can be used by the end-user without requiring any specific HW/SW (something that cannot be obtained in the public domain).
This ambiguity threw me off as to what we are actually providing is not a plugin framework for Quantum, but a framework for a Quantum Plugin to use multiple devices/switches, which is great! but we just have better elucidate the fact.
Hi Sumit,
First of all, Congratulations! to you, Edgar, Shweta and all others that have worked on creating this hunk of code. I concur the feelings of Salvatore and Dan and overall it looks well done!
I believe, Salvatore and Dan have done a extensive review and I believe everything looks pretty good. I did have one small comment regarding this merge-prop and "Define Quantum Plugin Interface for Python" blueprint.
At this point, the above referenced blueprint, which is a non vendor implementation specific, generic Quantum plugin, is already implemented and complete.
I was never under the impression the work contained in this merge-prop was specified under "Define Quantum Plugin Interface for Python" blueprint.
I do like the idea of "multi-switch plugin framework" that you guys have implemented as a generic framework for others to leverage, but I would unlink this branch from "Define Quantum Plugin Interface for Python" blueprint.
Reading the README, I believe we should call this a reference implementation of "Multi-switch plugin framework for a Quantum plugin using Cisco platform components" not "A reference implementation of plugin framework for L2 network."
An "reference implementation" is something that can be used by the end-user without requiring any specific HW/SW (something that cannot be obtained in the public domain).
This ambiguity threw me off as to what we are actually providing is not a plugin framework for Quantum, but a framework for a Quantum Plugin to use multiple devices/switches, which is great! but we just have better elucidate the fact.
Thanks,
Somik