Unity 8

Merge lp:~cimi/unity8/workaround_lp1324159 into lp:unity8

  1. workaround_lp1324159
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Approved by: Michael Terry
Approved revision: 932
Merged at revision: 952
Proposed branch: lp:~cimi/unity8/workaround_lp1324159
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
qml/Greeter/LoginList.qml (+1/-0)
To merge this branch: bzr merge lp:~cimi/unity8/workaround_lp1324159
Reviewer Review Type Date Requested Status
Michael Terry Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+221248@code.launchpad.net

Commit message

Workaround for lp1324159

Description of the change

See https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1324159

Might be an useful change, because empty passwords are not accepted anyway...

* Are there any related MPs required for this MP to build/function as expected? Please list.
No
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
 * Did you make sure that your branch does not contain spurious tags?
Yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:932
http://jenkins.qa.ubuntu.com/job/unity8-ci/3060/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/534
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/98
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/154
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/154/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/983
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1029
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1029/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/7842

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3060/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

LGTM. It should be OK to ignore Enter presses on empty text fields in the greeter for now. Passwords can't be empty. There are other theoretical prompts that PAM could ask, but I'm not sure how frequently empty answers are allowed in such cases. And we don't support that yet anyway, so this workaround is fine.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 - Yes

 * Did CI run pass? If not, please explain why.
 - Yes (yay!)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Greeter/LoginList.qml'
2--- qml/Greeter/LoginList.qml 2013-12-03 11:43:15 +0000
3+++ qml/Greeter/LoginList.qml 2014-05-28 14:51:25 +0000
4@@ -193,6 +193,7 @@
5 }
6
7 onAccepted: {
8+ if (text == "") return; // Might be useful anyway, but mainly workaround for LP 1324159
9 if (!enabled)
10 return;
11 root.focus = true; // so that it can handle Escape presses for us

Subscribers

People subscribed via source and target branches