Code review comment for lp:~cimi/unity8/unity8.hud-2_hint-reveal-commit

Michael Zanetti (mzanetti) wrote :

Is position really a double? Seems like a pixel value to me.

===

243 bool forceHidden() const;
244 + double position() const;
245 void setForceHidden(bool forceHidden);
246 + void setPosition(double position);

Usually we group them like this:

243 bool forceHidden() const;
245 void setForceHidden(bool forceHidden);

244 + double position() const;
246 + void setPosition(double position);

===

Can you move the _drag() method to some common place? maybe the __init__.py or something like that. I don't think copying that all over the place is a good idea.

review: Needs Fixing

« Back to merge proposal