Merge lp:~cimi/unity8/selected-to-normal-backgroundText into lp:unity8

[Andrea Cimitan]

replace selected.backgroundText with normal.backgroundText in Splash, Notifications, Wizard

We used selected.backgroundText in the past for white text on dark backgrounds. It recently changed to blue, and we realised we should have used normal.backgroundText with some proper fixes in the theme instead. The branch updates some colors that were still using selected palette to normal

 * Are there any related MPs required for this MP to build/function as expected? Please list.
from the prerequisite https://code.launchpad.net/~bzoltan/ubuntu-ui-toolkit/OTA10-landing-2016-01-20/+merge/283385
 * Did you perform an exploratory manual test run of your code change and any related functionality?
y
 * Did you make sure that your branch does not contain spurious tags?
y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

[Andrea Cimitan (cimi)]

 * Are there any related MPs required for this MP to build/function as expected? Please list.
from the prerequisite https://code.launchpad.net/~bzoltan/ubuntu-ui-toolkit/OTA10-landing-2016-01-20/+merge/283385
 * Did you perform an exploratory manual test run of your code change and any related functionality?
y
 * Did you make sure that your branch does not contain spurious tags?
y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2147
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/517/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/681/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/704
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/722
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/722
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/718
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/718/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/718/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/718
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/718/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/718
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/718/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/718
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/718/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/718/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/517/rebuild

review: Needs Fixing (continuous-integration)

[lp:~cimi/unity8/selected-to-normal-backgroundText]

2148. By Andrea Cimitan on 2016-02-29

merged

[Albert Astals Cid (aacid)]

Code looks good, waiting on silo to be available to do testing.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2148
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/534/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/700/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/723
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/741
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/741
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/737/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/737/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/737/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/737/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/737
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/737/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/737/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/534/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

silo testing looks good.

review: Approve

=== modified file 'qml/Notifications/Notification.qml'
--- qml/Notifications/Notification.qml	2015-11-06 15:52:24 +0000
+++ qml/Notifications/Notification.qml	2016-02-29 14:27:16 +0000
@@ -281,7 +281,7 @@
                         }
                         visible: type !== Notification.Confirmation
                         fontSize: "medium"
-                        color: darkOnBright ? sdFontColor : theme.palette.selected.backgroundText
+                        color: darkOnBright ? sdFontColor : theme.palette.normal.backgroundText
                         elide: Text.ElideRight
                         textFormat: Text.PlainText
                     }
@@ -296,7 +296,7 @@
                         }
                         visible: body != "" && type !== Notification.Confirmation
                         fontSize: "small"
-                        color: darkOnBright ? sdFontColor : theme.palette.selected.backgroundText
+                        color: darkOnBright ? sdFontColor : theme.palette.normal.backgroundText
                         wrapMode: Text.WordWrap
                         maximumLineCount: type == Notification.SnapDecision ? 12 : 2
                         elide: Text.ElideRight
@@ -337,7 +337,7 @@
                 anchors.horizontalCenter: parent.horizontalCenter
                 visible: type === Notification.Confirmation && body !== ""
                 fontSize: "medium"
-                color: darkOnBright ? sdFontColor : theme.palette.selected.backgroundText
+                color: darkOnBright ? sdFontColor : theme.palette.normal.backgroundText
                 wrapMode: Text.WordWrap
                 maximumLineCount: 1
                 elide: Text.ElideRight

=== modified file 'qml/Stages/Splash.qml'
--- qml/Stages/Splash.qml	2016-01-20 08:51:48 +0000
+++ qml/Stages/Splash.qml	2016-02-29 14:27:16 +0000
@@ -88,7 +88,7 @@
         panelForegroundColor: config.foregroundColor
         config: PageHeadConfiguration {
             id: headerConfig
-            foregroundColor: styledItem.fakeTheme.palette.selected.backgroundText
+            foregroundColor: styledItem.fakeTheme.palette.normal.backgroundText
         }
 
         property var contents: null
@@ -134,7 +134,7 @@
         anchors.topMargin: units.gu(2)
         fontSize: "large"
 
-        color: styledItem.fakeTheme.palette.selected.backgroundText
+        color: styledItem.fakeTheme.palette.normal.backgroundText
         visible: d.showIcon
     }
 

=== modified file 'qml/Wizard/StackButton.qml'
--- qml/Wizard/StackButton.qml	2015-07-15 15:07:19 +0000
+++ qml/Wizard/StackButton.qml	2016-02-29 14:27:16 +0000
@@ -32,7 +32,7 @@
         anchors.verticalCenter: parent.verticalCenter
         anchors.left: parent.left
         anchors.right: parent.right
-        color: enabled ? theme.palette.selected.backgroundText : Qt.darker(theme.palette.selected.backgroundText, 1.5)
+        color: enabled ? theme.palette.normal.backgroundText : Qt.darker(theme.palette.normal.backgroundText, 1.5)
         text: {
             if (backArrow) {
                 // Translators: This is the arrow for "Back" buttons