Merge lp:~cimi/unity8/scopeslist-sourcesize into lp:unity8

Proposed by Andrea Cimitan
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1613
Merged at revision: 1616
Proposed branch: lp:~cimi/unity8/scopeslist-sourcesize
Merge into: lp:unity8
Diff against target: 10 lines (+1/-0)
1 file modified
qml/Dash/ScopesListCategoryItem.qml (+1/-0)
To merge this branch: bzr merge lp:~cimi/unity8/scopeslist-sourcesize
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Review via email: mp+249629@code.launchpad.net

Commit message

Set sourcesize for scopes images in manage dash

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
y
 * Did you make sure that your branch does not contain spurious tags?
y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
1613. By Andrea Cimitan

Use shape item instead

Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Let's see...

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

The 1 qmluitest failed is unrelated and hopefully fixed at https://code.launchpad.net/~aacid/unity8/testNotificationsMoreStable/+merge/249625

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Dash/ScopesListCategoryItem.qml'
2--- qml/Dash/ScopesListCategoryItem.qml 2014-12-16 09:03:37 +0000
3+++ qml/Dash/ScopesListCategoryItem.qml 2015-02-13 12:04:01 +0000
4@@ -53,6 +53,7 @@
5 id: shapeImage
6 cache: true
7 fillMode: Image.PreserveAspectCrop
8+ sourceSize { width: shape.width; height: shape.height }
9 }
10 }
11

Subscribers

People subscribed via source and target branches