Merge lp:~cimi/unity8/redesign-pinned-apps into lp:unity8
Proposed by
Andrea Cimitan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michael Zanetti | ||||
Approved revision: | 1337 | ||||
Merged at revision: | 1347 | ||||
Proposed branch: | lp:~cimi/unity8/redesign-pinned-apps | ||||
Merge into: | lp:unity8 | ||||
Diff against target: |
175 lines (+26/-47) 3 files modified
qml/Launcher/LauncherDelegate.qml (+20/-33) qml/Launcher/LauncherPanel.qml (+5/-14) tests/mocks/Unity/Launcher/MockLauncherModel.cpp (+1/-0) |
||||
To merge this branch: | bzr merge lp:~cimi/unity8/redesign-pinned-apps | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Zanetti (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
Redesign for pinned apps. Remove thindivider on top of ubuntu dash button (not needed anymore)
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
y
To post a comment you must log in.
This doesn't work yet, the count emblem hides the pinned bubble. In my last design hangout I asked how to deal with that and there wasn't yet an answer for this. Vesa told me not to move the count emblem to the right as one of the design mockups suggests. So I think this is not ready to land yet.