Unity 8

Merge lp:~cimi/unity8/flick-speed-tuning into lp:unity8

  1. flick-speed-tuning
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 2561
Merged at revision: 2609
Proposed branch: lp:~cimi/unity8/flick-speed-tuning
Merge into: lp:unity8
Prerequisite: lp:~lukas-kde/unity8/wizardKeyboardPage
Diff against target: 577 lines (+190/-13)
33 files modified
qml/Components/Carousel.qml (+1/-2)
qml/Components/Flickable.qml (+24/-0)
qml/Components/FloatingFlickable.qml (+1/-0)
qml/Components/GridView.qml (+24/-0)
qml/Components/ListView.qml (+24/-0)
qml/Components/ResponsiveGridView.qml (+1/-0)
qml/Components/ZoomableImage.qml (+1/-1)
qml/Components/flickableUtils.js (+28/-0)
qml/Dash/DashContent.qml (+0/-2)
qml/Dash/DashNavigation.qml (+1/-0)
qml/Dash/FiltersPopover.qml (+1/-0)
qml/Dash/PageHeaderExtraPanel.qml (+1/-0)
qml/Dash/ScopeListView.qml (+4/-2)
qml/Dash/ScopesList.qml (+2/-0)
qml/Dash/ScopesListCategory.qml (+1/-0)
qml/Greeter/LoginList.qml (+0/-1)
qml/Launcher/LauncherPanel.qml (+1/-1)
qml/Panel/IndicatorPage.qml (+1/-0)
qml/Panel/Indicators/client/IndicatorsList.qml (+1/-0)
qml/Panel/Indicators/client/IndicatorsTree.qml (+1/-0)
qml/Wizard/Pages/10-welcome.qml (+1/-0)
qml/Wizard/Pages/20-keyboard.qml (+1/-0)
qml/Wizard/Pages/30-wifi.qml (+1/-0)
qml/Wizard/Pages/50-timezone.qml (+1/-0)
qml/Wizard/Pages/70-passwd-type.qml (+1/-0)
qml/Wizard/Pages/passcode-confirm.qml (+2/-2)
qml/Wizard/Pages/passcode-desktop.qml (+1/-0)
qml/Wizard/Pages/passcode-set.qml (+2/-2)
qml/Wizard/Pages/password-set.qml (+1/-0)
qml/Wizard/WizardItemSelector.qml (+1/-0)
tests/imports/check_imports.py (+58/-0)
tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml (+1/-0)
tests/qmltests/tst_OrientedShell.qml (+1/-0)
To merge this branch: bzr merge lp:~cimi/unity8/flick-speed-tuning
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Michael Zanetti testing Pending
Review via email: mp+302527@code.launchpad.net

This proposal supersedes a proposal from 2016-07-27.

Commit message

override some Qt Components definitions so we can have sane default values for flick speeds

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
n
 * Did you perform an exploratory manual test run of your code change and any related functionality?
y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2549
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1827/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2384
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1285/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1285
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1285
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2412
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2299
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2299
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2299
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2292/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2292
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2292/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1827/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2551
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1831/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1831/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2551
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1829/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2386
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1287
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1287
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1287
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2414
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2301
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2301
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2301
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2294/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2294
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2294/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1829/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote : Posted in a previous version of this proposal

tested on turbo, those values seem ok to me.

review: Approve (testing)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2552
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1900/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2476/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2504
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2391
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2391
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2391
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2384/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2384/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1900/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

You are excluding the qml files in Components from the check but i don't think is right.

If you create a folder with just
   main.qml: http://paste.ubuntu.com/22677937/
   ListView.qml: http://paste.ubuntu.com/22677983/

You will see that the "new" ListView is not picked up and you need
   import "."

So maybe instead excluding the qml files in Components you need to use a different pattern for the import?

Also please rename "uitk_pat" in your new function to something else, it's not the "UI ToolKit pattern" anymore.

review: Needs Fixing
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

The checker misses
   UnityComponents.Flickable {

i.e. if i remove
   import "../../Components" as UnityComponents
from
   qml/Wizard/Pages/passcode-desktop.qml

it won't find it's missing the import.

On the other hand it won't run either...

But i guess it could happen (not very common) that someone does
   import import QtQuick 2.4 as Quick
and then use
   Quick.ListView
and it would not be found.

Maybe you can change the pattern to not need the space before the Flickable/GridView/ListView and then manually exclude the Components/GridView.qml Components/Flickable.qml and Components/ListView.qml from the checking?

review: Needs Fixing
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Also tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml is "wrong" and is not found by the pattern (since it needs an space before Flickable {"

review: Needs Fixing
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2554
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1907/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2483/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2511
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2399
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2399
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2399
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2392/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2392/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2392/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2392/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2392/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2392/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2392/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2392/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2392
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2392/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1907/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2558
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1914/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2498/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2526
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2407
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2407
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2407
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2400/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2400/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2400/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2400/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2400/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2400/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2400/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2400/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2400
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2400/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1914/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2559
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1917/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2504/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2532
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2413
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2413
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2413
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2406/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2406/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2406/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2406/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2406/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2406/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2406/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2406/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2406
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2406/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1917/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

This unfortunately still doesn't detect

Flickable
{

since we're doing the pattern matching line by line. I can be convinced this is minor since we seldomly use that syntax.

Revision history for this message
Andrea Cimitan (cimi) wrote : Posted in a previous version of this proposal

> This unfortunately still doesn't detect
>
> Flickable
> {
>
> since we're doing the pattern matching line by line. I can be convinced this
> is minor since we seldomly use that syntax.

Yeah if you write that code I will notice it in the review :)

Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Ok, then

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Yes

review: Approve
Revision history for this message
Michał Sawicz (saviq) wrote : Posted in a previous version of this proposal

/«BUILDDIR»/unity8-8.14+16.10.20160809/qml/Wizard/WizardItemSelector.qml: missing/wrong order of Components import in line 128
/«BUILDDIR»/unity8-8.14+16.10.20160809/qml/Wizard/Pages/20-keyboard.qml: missing/wrong order of Components import in line 160

Would be good to rebase on lp:~lukas-kde/unity8/wizardKeyboardPage

Revision history for this message
Andrea Cimitan (cimi) wrote : Posted in a previous version of this proposal

> /«BUILDDIR»/unity8-8.14+16.10.20160809/qml/Wizard/WizardItemSelector.qml:
> missing/wrong order of Components import in line 128
> /«BUILDDIR»/unity8-8.14+16.10.20160809/qml/Wizard/Pages/20-keyboard.qml:
> missing/wrong order of Components import in line 160
>
> Would be good to rebase on lp:~lukas-kde/unity8/wizardKeyboardPage

good my new test is proving to work well at least :))

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2560
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1933/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2526
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1362
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1362
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1362
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2554
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2435
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2435
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2435
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2428/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2428
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2428/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1933/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

13:05:51 file:///tmp/autopkgtest.TCmt7E/build.tFv/unity8-8.14+16.10.20160803+vivid2435bzr2560/obj-x86_64-linux-gnu/tests/mocks/QtMultimedia/VideoSurface.qml:20:1: "../../../qml/Components": no such directory
13:05:51 import "../../../qml/Components"

mocks get installed elsewhere
so ../ won't work

Maybe we should exclude the tests folder from the check?

review: Needs Fixing
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2560
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1934/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2527
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1363/console
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1363/console
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1363
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2555
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2436
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2436
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2436
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2429/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2429
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2429/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1934/rebuild

review: Needs Fixing (continuous-integration)
lp:~cimi/unity8/flick-speed-tuning updated
2561. By Andrea Cimitan

redid the skip import test

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2561
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1935/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2531
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1366
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1366
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1366
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2559
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2440
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2440
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2440
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2433/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2433
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2433/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1935/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1952/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2551/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2579
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2459
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2459
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2459
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2452/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2452/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2452/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2452/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2452/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2452/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2452/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2452/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2452
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2452/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1952/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1957/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/2556/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2584
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2464
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2464
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2464
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2458/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2458/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2458/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2458/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2458/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2458/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2458/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2458/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2458
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2458/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1957/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Approve-yet-again

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1962/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2561
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1385
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1385
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1385
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2589
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2469
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2469
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2469
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2463/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2463
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2463/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1962/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2561
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1977/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2596
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1412
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1412/console
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1412
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2624
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2504
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2504
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2504
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2498/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2498
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2498/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1977/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2561
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2119/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2787
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1542
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1542
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1542
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2815
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2675/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2675
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2675/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2119/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Components/Carousel.qml'
2--- qml/Components/Carousel.qml 2015-09-14 07:47:24 +0000
3+++ qml/Components/Carousel.qml 2016-08-10 16:11:22 +0000
4@@ -17,6 +17,7 @@
5 import QtQuick 2.4
6 import Ubuntu.Components 1.3
7 import "carousel.js" as CarouselJS
8+import "."
9
10 /*! The Carousel component presents the items of a model in a carousel view. It's similar to a
11 cover flow. But it stops at it's boundaries (therefore no PathView is used).
12@@ -141,8 +142,6 @@
13
14 boundsBehavior: Flickable.DragOverBounds
15 cacheBuffer: carousel.cacheBuffer
16- flickDeceleration: Math.max(1500 * Math.pow(realWidth / referenceWidth, 1.5), 1500) // 1500 is platform default
17- maximumFlickVelocity: Math.max(2500 * Math.pow(realWidth / referenceWidth, 1.5), 2500) // 2500 is platform default
18 orientation: ListView.Horizontal
19
20 function getXFromContinuousIndex(index) {
21
22=== added file 'qml/Components/Flickable.qml'
23--- qml/Components/Flickable.qml 1970-01-01 00:00:00 +0000
24+++ qml/Components/Flickable.qml 2016-08-10 16:11:22 +0000
25@@ -0,0 +1,24 @@
26+/*
27+ * Copyright (C) 2016 Canonical, Ltd.
28+ *
29+ * This program is free software; you can redistribute it and/or modify
30+ * it under the terms of the GNU General Public License as published by
31+ * the Free Software Foundation; version 3.
32+ *
33+ * This program is distributed in the hope that it will be useful,
34+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
35+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
36+ * GNU General Public License for more details.
37+ *
38+ * You should have received a copy of the GNU General Public License
39+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
40+ */
41+
42+import QtQuick 2.4 as QtQuick
43+import Ubuntu.Components 1.3
44+import "flickableUtils.js" as FlickableUtilsJS
45+
46+QtQuick.Flickable {
47+ flickDeceleration: FlickableUtilsJS.getFlickDeceleration(units.gridUnit)
48+ maximumFlickVelocity: FlickableUtilsJS.getMaximumFlickVelocity(units.gridUnit)
49+}
50\ No newline at end of file
51
52=== modified file 'qml/Components/FloatingFlickable.qml'
53--- qml/Components/FloatingFlickable.qml 2016-01-11 16:57:07 +0000
54+++ qml/Components/FloatingFlickable.qml 2016-08-10 16:11:22 +0000
55@@ -17,6 +17,7 @@
56 import QtQuick 2.4
57 import Ubuntu.Components 1.3
58 import Ubuntu.Gestures 0.1
59+import "."
60
61 /*
62 A Flickable that can be put in front of the item to be flicked and
63
64=== added file 'qml/Components/GridView.qml'
65--- qml/Components/GridView.qml 1970-01-01 00:00:00 +0000
66+++ qml/Components/GridView.qml 2016-08-10 16:11:22 +0000
67@@ -0,0 +1,24 @@
68+/*
69+ * Copyright (C) 2016 Canonical, Ltd.
70+ *
71+ * This program is free software; you can redistribute it and/or modify
72+ * it under the terms of the GNU General Public License as published by
73+ * the Free Software Foundation; version 3.
74+ *
75+ * This program is distributed in the hope that it will be useful,
76+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
77+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
78+ * GNU General Public License for more details.
79+ *
80+ * You should have received a copy of the GNU General Public License
81+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
82+ */
83+
84+import QtQuick 2.4 as QtQuick
85+import Ubuntu.Components 1.3
86+import "flickableUtils.js" as FlickableUtilsJS
87+
88+QtQuick.GridView {
89+ flickDeceleration: FlickableUtilsJS.getFlickDeceleration(units.gridUnit)
90+ maximumFlickVelocity: FlickableUtilsJS.getMaximumFlickVelocity(units.gridUnit)
91+}
92\ No newline at end of file
93
94=== added file 'qml/Components/ListView.qml'
95--- qml/Components/ListView.qml 1970-01-01 00:00:00 +0000
96+++ qml/Components/ListView.qml 2016-08-10 16:11:22 +0000
97@@ -0,0 +1,24 @@
98+/*
99+ * Copyright (C) 2016 Canonical, Ltd.
100+ *
101+ * This program is free software; you can redistribute it and/or modify
102+ * it under the terms of the GNU General Public License as published by
103+ * the Free Software Foundation; version 3.
104+ *
105+ * This program is distributed in the hope that it will be useful,
106+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
107+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
108+ * GNU General Public License for more details.
109+ *
110+ * You should have received a copy of the GNU General Public License
111+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
112+ */
113+
114+import QtQuick 2.4 as QtQuick
115+import Ubuntu.Components 1.3
116+import "flickableUtils.js" as FlickableUtilsJS
117+
118+QtQuick.ListView {
119+ flickDeceleration: FlickableUtilsJS.getFlickDeceleration(units.gridUnit)
120+ maximumFlickVelocity: FlickableUtilsJS.getMaximumFlickVelocity(units.gridUnit)
121+}
122\ No newline at end of file
123
124=== modified file 'qml/Components/ResponsiveGridView.qml'
125--- qml/Components/ResponsiveGridView.qml 2016-01-13 09:00:03 +0000
126+++ qml/Components/ResponsiveGridView.qml 2016-08-10 16:11:22 +0000
127@@ -16,6 +16,7 @@
128
129 import QtQuick 2.4
130 import Ubuntu.Components 1.3
131+import "."
132
133 /*
134 Essentially a GridView
135
136=== modified file 'qml/Components/ZoomableImage.qml'
137--- qml/Components/ZoomableImage.qml 2016-01-22 23:16:50 +0000
138+++ qml/Components/ZoomableImage.qml 2016-08-10 16:11:22 +0000
139@@ -16,7 +16,7 @@
140
141 import QtQuick 2.4
142 import Ubuntu.Components 1.3
143-import "../Components"
144+import "."
145
146 /*! \brief Zoomable for image.
147
148
149=== added file 'qml/Components/flickableUtils.js'
150--- qml/Components/flickableUtils.js 1970-01-01 00:00:00 +0000
151+++ qml/Components/flickableUtils.js 2016-08-10 16:11:22 +0000
152@@ -0,0 +1,28 @@
153+/*
154+ * Copyright (C) 2016 Canonical, Ltd.
155+ *
156+ * This program is free software; you can redistribute it and/or modify
157+ * it under the terms of the GNU General Public License as published by
158+ * the Free Software Foundation; version 3.
159+ *
160+ * This program is distributed in the hope that it will be useful,
161+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
162+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
163+ * GNU General Public License for more details.
164+ *
165+ * You should have received a copy of the GNU General Public License
166+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
167+ */
168+
169+.pragma library
170+
171+/* TODO the "8" is is DEFAULT_GRID_UNIT_PX, we use it to normalize the values with the current grid unit size.
172+ Add a way to fetch this default grid unit px value from UITK. */
173+
174+function getFlickDeceleration(gridUnit) {
175+ return 1500 * gridUnit / 8;
176+}
177+
178+function getMaximumFlickVelocity(gridUnit) {
179+ return 2500 * gridUnit / 8;
180+}
181\ No newline at end of file
182
183=== modified file 'qml/Dash/DashContent.qml'
184--- qml/Dash/DashContent.qml 2016-03-29 03:47:39 +0000
185+++ qml/Dash/DashContent.qml 2016-08-10 16:11:22 +0000
186@@ -112,8 +112,6 @@
187 anchors.fill: parent
188 orientation: ListView.Horizontal
189 boundsBehavior: Flickable.DragAndOvershootBounds
190- flickDeceleration: units.gu(625)
191- maximumFlickVelocity: width * 5
192 snapMode: ListView.SnapOneItem
193 highlightMoveDuration: 250
194 highlightRangeMode: ListView.StrictlyEnforceRange
195
196=== modified file 'qml/Dash/DashNavigation.qml'
197--- qml/Dash/DashNavigation.qml 2016-03-29 03:47:39 +0000
198+++ qml/Dash/DashNavigation.qml 2016-08-10 16:11:22 +0000
199@@ -17,6 +17,7 @@
200 import QtQuick 2.4
201 import Ubuntu.Components 1.3
202 import Dash 0.1
203+import "../Components"
204
205 Item {
206 id: root
207
208=== modified file 'qml/Dash/FiltersPopover.qml'
209--- qml/Dash/FiltersPopover.qml 2016-03-14 08:54:07 +0000
210+++ qml/Dash/FiltersPopover.qml 2016-08-10 16:11:22 +0000
211@@ -19,6 +19,7 @@
212 import Ubuntu.Components.Popups 1.3
213 import Ubuntu.Components.ListItems 1.3 as ListItems
214 import "Filters" as Filters
215+import "../Components"
216
217 Popover {
218 id: root
219
220=== modified file 'qml/Dash/PageHeaderExtraPanel.qml'
221--- qml/Dash/PageHeaderExtraPanel.qml 2016-05-05 18:16:20 +0000
222+++ qml/Dash/PageHeaderExtraPanel.qml 2016-08-10 16:11:22 +0000
223@@ -18,6 +18,7 @@
224 import Ubuntu.Components 1.3
225 import Ubuntu.Components.ListItems 1.3 as ListItems
226 import "Filters" as Filters
227+import "../Components"
228
229 Item {
230 id: root
231
232=== modified file 'qml/Dash/ScopeListView.qml'
233--- qml/Dash/ScopeListView.qml 2015-07-15 15:07:19 +0000
234+++ qml/Dash/ScopeListView.qml 2016-08-10 16:11:22 +0000
235@@ -15,11 +15,13 @@
236 */
237
238 import QtQuick 2.4
239+import Ubuntu.Components 1.3
240 import Dash 0.1
241+import "../Components/flickableUtils.js" as FlickableUtilsJS
242
243 ListViewWithPageHeader {
244- maximumFlickVelocity: height * 10
245- flickDeceleration: height * 2
246+ flickDeceleration: FlickableUtilsJS.getFlickDeceleration(units.gridUnit)
247+ maximumFlickVelocity: FlickableUtilsJS.getMaximumFlickVelocity(units.gridUnit)
248 // 1073741823 is s^30 -1. A quite big number so that you have "infinite" cache, but not so
249 // big so that if you add if with itself you're outside the 2^31 int range
250 cacheBuffer: 1073741823
251
252=== modified file 'qml/Dash/ScopesList.qml'
253--- qml/Dash/ScopesList.qml 2016-06-08 13:13:43 +0000
254+++ qml/Dash/ScopesList.qml 2016-08-10 16:11:22 +0000
255@@ -15,7 +15,9 @@
256 */
257
258 import QtQuick 2.4
259+import Ubuntu.Components 1.3
260 import Dash 0.1
261+import "../Components"
262
263 Item {
264 id: root
265
266=== modified file 'qml/Dash/ScopesListCategory.qml'
267--- qml/Dash/ScopesListCategory.qml 2015-07-15 15:07:19 +0000
268+++ qml/Dash/ScopesListCategory.qml 2016-08-10 16:11:22 +0000
269@@ -17,6 +17,7 @@
270 import QtQuick 2.4
271 import Ubuntu.Components 1.3
272 import Dash 0.1
273+import "../Components"
274 import "../Components/ListItems" as ListItems
275
276 Item {
277
278=== modified file 'qml/Greeter/LoginList.qml'
279--- qml/Greeter/LoginList.qml 2016-06-27 18:32:47 +0000
280+++ qml/Greeter/LoginList.qml 2016-08-10 16:11:22 +0000
281@@ -152,7 +152,6 @@
282 preferredHighlightEnd: userList.height / 2 - root.highlightedHeight / 2
283 highlightRangeMode: ListView.StrictlyEnforceRange
284 highlightMoveDuration: root.moveDuration
285- flickDeceleration: 10000
286 interactive: count > 1
287
288 readonly property bool movingInternally: moveTimer.running || userList.moving
289
290=== modified file 'qml/Launcher/LauncherPanel.qml'
291--- qml/Launcher/LauncherPanel.qml 2016-07-27 14:51:26 +0000
292+++ qml/Launcher/LauncherPanel.qml 2016-08-10 16:11:22 +0000
293@@ -19,7 +19,7 @@
294 import Unity.Launcher 0.1
295 import Ubuntu.Components.Popups 1.3
296 import "../Components/ListItems"
297-import "../Components/"
298+import "../Components"
299
300 Rectangle {
301 id: root
302
303=== modified file 'qml/Panel/IndicatorPage.qml'
304--- qml/Panel/IndicatorPage.qml 2015-09-29 12:28:10 +0000
305+++ qml/Panel/IndicatorPage.qml 2016-08-10 16:11:22 +0000
306@@ -17,6 +17,7 @@
307 import QtQuick 2.4
308 import Ubuntu.Components 1.3 as Components
309 import Unity.Indicators 0.1 as Indicators
310+import "../Components"
311 import "Indicators"
312
313 IndicatorBase {
314
315=== modified file 'qml/Panel/Indicators/client/IndicatorsList.qml'
316--- qml/Panel/Indicators/client/IndicatorsList.qml 2016-06-14 10:32:17 +0000
317+++ qml/Panel/Indicators/client/IndicatorsList.qml 2016-08-10 16:11:22 +0000
318@@ -22,6 +22,7 @@
319 import Ubuntu.Components.ListItems 1.3 as ListItem
320 import Unity.Indicators 0.1 as Indicators
321 import "../.."
322+import "../../../Components"
323
324 Page {
325 id: page
326
327=== modified file 'qml/Panel/Indicators/client/IndicatorsTree.qml'
328--- qml/Panel/Indicators/client/IndicatorsTree.qml 2015-07-15 15:07:19 +0000
329+++ qml/Panel/Indicators/client/IndicatorsTree.qml 2016-08-10 16:11:22 +0000
330@@ -21,6 +21,7 @@
331 import Ubuntu.Components 1.3
332 import Unity.Indicators 0.1 as Indicators
333 import ".."
334+import "../../../Components"
335
336 IndicatorBase {
337 id: root
338
339=== modified file 'qml/Wizard/Pages/10-welcome.qml'
340--- qml/Wizard/Pages/10-welcome.qml 2016-06-06 15:08:02 +0000
341+++ qml/Wizard/Pages/10-welcome.qml 2016-08-10 16:11:22 +0000
342@@ -20,6 +20,7 @@
343 import Ubuntu.SystemSettings.LanguagePlugin 1.0
344 import Wizard 0.1
345 import ".." as LocalComponents
346+import "../../Components"
347
348 LocalComponents.Page {
349 objectName: "languagePage"
350
351=== modified file 'qml/Wizard/Pages/20-keyboard.qml'
352--- qml/Wizard/Pages/20-keyboard.qml 2016-08-10 16:11:21 +0000
353+++ qml/Wizard/Pages/20-keyboard.qml 2016-08-10 16:11:22 +0000
354@@ -23,6 +23,7 @@
355 import Unity.InputInfo 0.1
356 import Unity.Application 0.1
357 import ".." as LocalComponents
358+import "../../Components"
359
360 LocalComponents.Page {
361 objectName: "keyboardPage"
362
363=== modified file 'qml/Wizard/Pages/30-wifi.qml'
364--- qml/Wizard/Pages/30-wifi.qml 2016-03-29 03:47:39 +0000
365+++ qml/Wizard/Pages/30-wifi.qml 2016-08-10 16:11:22 +0000
366@@ -21,6 +21,7 @@
367 import Wizard 0.1
368 import Ubuntu.Connectivity 1.0
369 import ".." as LocalComponents
370+import "../../Components"
371
372 LocalComponents.Page {
373 id: wifiPage
374
375=== modified file 'qml/Wizard/Pages/50-timezone.qml'
376--- qml/Wizard/Pages/50-timezone.qml 2016-04-05 19:57:51 +0000
377+++ qml/Wizard/Pages/50-timezone.qml 2016-08-10 16:11:22 +0000
378@@ -21,6 +21,7 @@
379 import Ubuntu.SystemSettings.TimeDate 1.1
380 import Utils 0.1 as Utils
381 import ".." as LocalComponents
382+import "../../Components"
383
384 LocalComponents.Page {
385 id: tzPage
386
387=== modified file 'qml/Wizard/Pages/70-passwd-type.qml'
388--- qml/Wizard/Pages/70-passwd-type.qml 2016-03-29 03:47:39 +0000
389+++ qml/Wizard/Pages/70-passwd-type.qml 2016-08-10 16:11:22 +0000
390@@ -19,6 +19,7 @@
391 import Ubuntu.Components.ListItems 1.3
392 import Ubuntu.SystemSettings.SecurityPrivacy 1.0
393 import ".." as LocalComponents
394+import "../../Components"
395
396 /**
397 * One quirk with this page: we don't actually set the password. We avoid
398
399=== modified file 'qml/Wizard/Pages/passcode-confirm.qml'
400--- qml/Wizard/Pages/passcode-confirm.qml 2016-03-29 03:47:39 +0000
401+++ qml/Wizard/Pages/passcode-confirm.qml 2016-08-10 16:11:22 +0000
402@@ -18,7 +18,7 @@
403 import Ubuntu.Components 1.3
404 import Ubuntu.SystemSettings.SecurityPrivacy 1.0
405 import ".." as LocalComponents
406-import "../../Components" as UnityComponents
407+import "../../Components"
408
409 /**
410 * See the main passwd-type page for an explanation of why we don't actually
411@@ -34,7 +34,7 @@
412 // If we are entering this page, clear any saved password and get focus
413 onEnabledChanged: if (enabled) lockscreen.clear(false)
414
415- UnityComponents.Lockscreen {
416+ Lockscreen {
417 id: lockscreen
418 anchors {
419 fill: content
420
421=== modified file 'qml/Wizard/Pages/passcode-desktop.qml'
422--- qml/Wizard/Pages/passcode-desktop.qml 2016-06-09 15:27:58 +0000
423+++ qml/Wizard/Pages/passcode-desktop.qml 2016-08-10 16:11:22 +0000
424@@ -18,6 +18,7 @@
425 import QtQuick.Layouts 1.1
426 import Ubuntu.Components 1.3
427 import ".." as LocalComponents
428+import "../../Components"
429
430 /**
431 * See the main passwd-type page for an explanation of why we don't actually
432
433=== modified file 'qml/Wizard/Pages/passcode-set.qml'
434--- qml/Wizard/Pages/passcode-set.qml 2016-03-29 03:47:39 +0000
435+++ qml/Wizard/Pages/passcode-set.qml 2016-08-10 16:11:22 +0000
436@@ -18,7 +18,7 @@
437 import Ubuntu.Components 1.3
438 import Ubuntu.SystemSettings.SecurityPrivacy 1.0
439 import ".." as LocalComponents
440-import "../../Components" as UnityComponents
441+import "../../Components"
442
443 /**
444 * See the main passwd-type page for an explanation of why we don't actually
445@@ -45,7 +45,7 @@
446 onTriggered: pageStack.load(Qt.resolvedUrl("passcode-confirm.qml"));
447 }
448
449- UnityComponents.Lockscreen {
450+ Lockscreen {
451 id: lockscreen
452 anchors {
453 fill: content
454
455=== modified file 'qml/Wizard/Pages/password-set.qml'
456--- qml/Wizard/Pages/password-set.qml 2016-03-16 11:38:39 +0000
457+++ qml/Wizard/Pages/password-set.qml 2016-08-10 16:11:22 +0000
458@@ -18,6 +18,7 @@
459 import QtQuick.Layouts 1.1
460 import Ubuntu.Components 1.3
461 import ".." as LocalComponents
462+import "../../Components"
463
464 /**
465 * See the main passwd-type page for an explanation of why we don't actually
466
467=== modified file 'qml/Wizard/WizardItemSelector.qml'
468--- qml/Wizard/WizardItemSelector.qml 2016-08-10 16:11:21 +0000
469+++ qml/Wizard/WizardItemSelector.qml 2016-08-10 16:11:22 +0000
470@@ -17,6 +17,7 @@
471 import QtQuick 2.4
472 import Ubuntu.Components 1.3
473 import Ubuntu.Components.ListItems 1.3 as ListItem
474+import "../Components"
475
476 Rectangle {
477 id: optionToggle
478
479=== modified file 'tests/imports/check_imports.py'
480--- tests/imports/check_imports.py 2015-07-15 15:13:18 +0000
481+++ tests/imports/check_imports.py 2016-08-10 16:11:22 +0000
482@@ -81,6 +81,53 @@
483 print("%s: bad import version in multiple lines" % file_path)
484 return bool(errors)
485
486+# Flickable matches
487+flickable_pat = re.compile(r'.*\s*Flickable\s*{')
488+listview_pat = re.compile(r'.*\s*ListView\s*{')
489+gridview_pat = re.compile(r'.*\s*GridView\s*{')
490+flickable_pats = [flickable_pat, listview_pat, gridview_pat]
491+unity_components_pat = re.compile(r'.*import ".*Components"')
492+components_import_pat = re.compile(r'.*import "."')
493+components_path = re.compile(r'.*qml/Components.*')
494+skip_components_flickable_path = re.compile(r'.*qml/Components/Flickable.qml')
495+skip_components_listview_path = re.compile(r'.*qml/Components/ListView.qml')
496+skip_components_gridview_path = re.compile(r'.*qml/Components/GridView.qml')
497+skip_mocks_path = re.compile(r'.*tests/mocks.*')
498+
499+def scan_for_flickable_imports(file_path, component_pats, qtquick_pat, unitycomponents_pat):
500+ errors = []
501+ with open(file_path, 'rt', encoding='utf-8') as ifile, open(file_path, 'rt', encoding='utf-8') as i2file:
502+ flickable_found = False
503+ for lino, line in enumerate(ifile, start=1):
504+ for component_pat in component_pats:
505+ if component_pat.match(line):
506+ flickable_found = True
507+ if flickable_found:
508+ qtquick_found = False
509+ unitycomponents_found = False
510+ for lino, line in enumerate(i2file, start=1):
511+ if not qtquick_found and qtquick_pat.match(line):
512+ qtquick_found = True
513+ if unitycomponents_pat.match(line):
514+ unitycomponents_found = True
515+ if not qtquick_found:
516+ errors.append(lino)
517+ else:
518+ return
519+ if not unitycomponents_found:
520+ errors.append(lino)
521+ if 0 < len(errors) <= 10:
522+ if len(errors) > 1:
523+ plural = 's'
524+ else:
525+ plural = ''
526+ print(
527+ "%s: missing/wrong order of Components import in line%s %s" % (
528+ file_path, plural, ", ".join((str(i) for i in errors))))
529+ elif errors:
530+ print("%s: missing/wrong order of Components imports in multiple lines" % file_path)
531+ return bool(errors)
532+
533 # Parse args
534
535 parser = argparse.ArgumentParser(
536@@ -116,6 +163,17 @@
537 found_bad_import = True
538 if scan_for_bad_import(path, ubuntu_components_pat, [ubuntu_good_components_pat]):
539 found_bad_import = True
540+ if skip_mocks_path.match(path) or \
541+ skip_components_flickable_path.match(path) or \
542+ skip_components_listview_path.match(path) or \
543+ skip_components_gridview_path.match(path):
544+ break
545+ if not components_path.match(path):
546+ if scan_for_flickable_imports(path, flickable_pats, quick_good_pat, unity_components_pat):
547+ found_bad_import = True
548+ else:
549+ if scan_for_flickable_imports(path, flickable_pats, quick_good_pat, components_import_pat):
550+ found_bad_import = True
551
552 except OSError as e:
553 error("cannot create file list for \"" + dir + "\": " + e.strerror)
554
555=== modified file 'tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml'
556--- tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml 2016-06-23 08:20:23 +0000
557+++ tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml 2016-08-10 16:11:22 +0000
558@@ -18,6 +18,7 @@
559 import QtTest 1.0
560 import Ubuntu.Components 1.3
561 import "../../../../qml/Dash/Previews"
562+import "../../../../qml/Components"
563 import Unity.Test 0.1 as UT
564
565 Flickable {
566
567=== modified file 'tests/qmltests/tst_OrientedShell.qml'
568--- tests/qmltests/tst_OrientedShell.qml 2016-07-29 20:25:09 +0000
569+++ tests/qmltests/tst_OrientedShell.qml 2016-08-10 16:11:22 +0000
570@@ -28,6 +28,7 @@
571 import Utils 0.1
572
573 import "../../qml"
574+import "../../qml/Components"
575 import "Stages"
576
577 Rectangle {

Subscribers

People subscribed via source and target branches