Merge lp:~cimi/unity8/fix-single-preview-ap-tests into lp:unity8

[Andrea Cimitan]

Update AP tests for new single preview

 * Are there any related MPs required for this MP to build/function as expected? Please list.
n
 * Did you perform an exploratory manual test run of your code change and any related functionality?
y
 * Did you make sure that your branch does not contain spurious tags?
y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2215
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/609/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/342
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/342
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/342
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/801
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/817
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/817
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/815/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/815
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/815/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/609/rebuild

review: Approve (continuous-integration)

[Michał Sawicz (saviq)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
CI happy
 * Did CI run pass? If not, please explain why.
Yup
 * Did you make sure that the branch does not contain spurious tags?
Y

review: Approve

=== modified file 'tests/autopilot/unity8/dash.py'
--- tests/autopilot/unity8/dash.py	2015-12-11 09:10:01 +0000
+++ tests/autopilot/unity8/dash.py	2016-03-07 11:58:31 +0000
@@ -211,8 +211,7 @@
         self.get_root_instance().select_single(
             objectName='processingIndicator').visible.wait_for(False)
         return preview_list.select_single(
-            Preview, objectName='preview{}'.format(
-                preview_list.initialIndex))
+            Preview, objectName='preview')
 
     @autopilot_logging.log_action(logger.debug)
     def click_scope_item(self, category, title, press_duration=0.10):

=== modified file 'tests/autopilot/unity8/shell/tests/test_helpers.py'
--- tests/autopilot/unity8/shell/tests/test_helpers.py	2015-09-03 07:44:51 +0000
+++ tests/autopilot/unity8/shell/tests/test_helpers.py	2016-03-07 11:58:31 +0000
@@ -117,13 +117,11 @@
     def test_open_preview(self):
         preview = self.generic_scope.open_preview('0', 'Title.0.0')
         self.assertIsInstance(preview, dash_helpers.Preview)
-        self.assertTrue(preview.isCurrent)
 
     def test_open_preview_of_non_visible_item(self):
         """Open an item that requires swiping to make it visible."""
         preview = self.generic_scope.open_preview('2', 'Title.2.0')
         self.assertIsInstance(preview, dash_helpers.Preview)
-        self.assertTrue(preview.isCurrent)
 
 
 class DashAppsHelperTestCase(tests.DashBaseTestCase):