Unity 8

Merge lp:~cimi/unity8/fix-1378920 into lp:unity8

  1. fix-1378920
  2. Merge into trunk
Proposed by Andrea Cimitan on 2014-10-10
Status: Rejected
Rejected by: Michał Sawicz on 2014-10-20
Proposed branch: lp:~cimi/unity8/fix-1378920
Merge into: lp:unity8
Diff against target: 10 lines (+1/-0)
1 file modified
qml/Notifications/Notification.qml (+1/-0)
To merge this branch: bzr merge lp:~cimi/unity8/fix-1378920
Reviewer Review Type Date Requested Status
Michał Sawicz Disapprove on 2014-10-20
PS Jenkins bot continuous-integration Needs Fixing on 2014-10-20
Mirco Müller 2014-10-10 Pending
Review via email: mp+238012@code.launchpad.net

Commit Message

Change audioRole to MediaPlayer.alert for Notifications

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * Did you make sure that your branch does not contain spurious tags?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
n/a

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1355
http://jenkins.qa.ubuntu.com/job/unity8-ci/4617/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5838
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1603
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1713
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1711
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5487
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7090
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7090/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14530

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4617/rebuild

review: Needs Fixing (continuous-integration)
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1355
http://jenkins.qa.ubuntu.com/job/unity8-ci/4701/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6055
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/1687
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1797
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1795
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5688
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7307
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7307/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14851

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4701/rebuild

review: Needs Fixing (continuous-integration)
Michał Sawicz (saviq) wrote :
review: Disapprove

Unmerged revisions

1355. By Andrea Cimitan on 2014-10-10

Fix for 1378920

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Notifications/Notification.qml'
2--- qml/Notifications/Notification.qml 2014-09-18 21:25:00 +0000
3+++ qml/Notifications/Notification.qml 2014-10-10 16:59:57 +0000
4@@ -77,6 +77,7 @@
5 Audio {
6 id: sound
7 objectName: "sound"
8+ audioRole: MediaPlayer.alert
9 source: hints["suppress-sound"] != "true" && hints["sound-file"] != undefined ? hints["sound-file"] : ""
10 }
11

Subscribers

People subscribed via source and target branches