Merge lp:~cimi/unity8/fix-1231731 into lp:unity8

[Andrea Cimitan]

Shifts wallpaper rendering for greeter lockscreen to be inline with shell

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:467
http://jenkins.qa.ubuntu.com/job/unity8-ci/1428/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/5056
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2996/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2296
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/451
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1428
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1428/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1427
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1225
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/931
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/931/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2998
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2998/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2503/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2547
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/16
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/14

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1428/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:467
http://jenkins.qa.ubuntu.com/job/unity8-ci/1433/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/5065
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/3004
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2301
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/456
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1433
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1433/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1432
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1233
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/940
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/940/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/3006
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/3006/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2511
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2555
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/32
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/28

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1433/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Do you think makes sense to add an autotest that checks that the height, width, x, y of the greeter CrossFadeImage background image and the dash CrossFadeImage background image are the same?

review: Needs Information

[Andrea Cimitan (cimi)]

> Do you think makes sense to add an autotest that checks that the height,
> width, x, y of the greeter CrossFadeImage background image and the dash
> CrossFadeImage background image are the same?

it does, you need to fire up the whole shell though (greeter needs reference to panel)
maybe autopilot is easier?

[Albert Astals Cid (aacid)]

No strong preference for qmltest/autopilot test, whatever you think it's easier :-)

[Michael Zanetti (mzanetti)]

I don't think you should access the "panel" in here. This will break once the Greeter is split out from the shell. Make it a property (e.g. topMargin) which you set from a place where the panel is available for real.

review: Needs Information

[Andrea Cimitan (cimi)]

> I don't think you should access the "panel" in here. This will break once the
> Greeter is split out from the shell. Make it a property (e.g. topMargin) which
> you set from a place where the panel is available for real.

valid point

[lp:~cimi/unity8/fix-1231731]

468. By Andrea Cimitan on 2013-10-22

Added test for greeter wallpaper, changed some names from wallpaper->background

469. By Andrea Cimitan on 2013-10-22

Added property for backgroundTopMargin

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:468
http://jenkins.qa.ubuntu.com/job/unity8-ci/1471/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/5129
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/3150/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2343
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/494
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1475
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1475/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1470
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1293
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/1004
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/1004/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/3152
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/3152/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2630/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2681/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/291
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/290

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1471/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:469
http://jenkins.qa.ubuntu.com/job/unity8-ci/1474/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/5133
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/3157/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-saucy/2346
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-amd64-ci/497
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1478
        deb: http://jenkins.qa.ubuntu.com/job/unity8-saucy-armhf-ci/1478/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-saucy-i386-ci/1473
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/1296
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/1008
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/1008/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/3159
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/3159/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2635/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2686/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/305
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/298

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1474/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

This looks good to me now. However, the same issue is still present in the Lockscreen. Should we fix that too? Actually the lockscreen shouldn't have a background but do heavy blurring of the stuff behind it. Not sure how long the blurring will still take. Maybe it's worth applying this fix there too in the meantime.

review: Needs Information

[lp:~cimi/unity8/fix-1231731]

470. By Andrea Cimitan on 2013-10-25

Fix Lockscreen background and add test

471. By Andrea Cimitan on 2013-10-25

Delete tags

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:470
http://jenkins.qa.ubuntu.com/job/unity8-ci/1496/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/104/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/98/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/20
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/20
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/20/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/20
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/98/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/104
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/104/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/98
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/98/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2725
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2776/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/496
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/478

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1496/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:471
http://jenkins.qa.ubuntu.com/job/unity8-ci/1499/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/114/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/108/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/23
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/108/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/114
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/114/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/108
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/108/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2734/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2785/console
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/508
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/506

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1499/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Looks good to me now :-)

review: Approve

[Michael Zanetti (mzanetti)]

+1

review: Approve

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'Greeter/Greeter.qml'
--- Greeter/Greeter.qml	2013-09-13 15:17:02 +0000
+++ Greeter/Greeter.qml	2013-10-25 13:49:16 +0000
@@ -64,6 +64,7 @@
         property var model: LightDM.Users
         property int currentIndex: 0
         property var infographicModel: LightDM.Infographic
+        readonly property int backgroundTopMargin: -greeter.y
 
         source: required ? "GreeterContent.qml" : ""
 

=== modified file 'Greeter/GreeterContent.qml'
--- Greeter/GreeterContent.qml	2013-10-03 04:28:13 +0000
+++ Greeter/GreeterContent.qml	2013-10-25 13:49:16 +0000
@@ -24,7 +24,7 @@
     id: root
     anchors.fill: parent
 
-    property bool ready: wallpaper.source == "" || wallpaper.status == Image.Ready || wallpaper.status == Image.Error
+    property bool ready: background.source == "" || background.status == Image.Ready || background.status == Image.Error
     property bool leftTeaserPressed: teasingMouseArea.pressed &&
                                      teasingMouseArea.mouseX < teasingMouseArea.width / 2
     property bool rightTeaserPressed: teasingMouseArea.pressed &&
@@ -34,33 +34,36 @@
     signal unlocked(int uid)
 
     Rectangle {
-        // In case wallpaper fails to load
-        id: wallpaperBackup
+        // In case background fails to load
+        id: backgroundBackup
         anchors.fill: parent
         color: "black"
     }
 
     property url backgroundValue: AccountsService.backgroundFile != undefined && AccountsService.backgroundFile.length > 0 ? AccountsService.backgroundFile : greeter.defaultBackground
-    onBackgroundValueChanged: wallpaper.source = backgroundValue
+    onBackgroundValueChanged: background.source = backgroundValue
 
     CrossFadeImage {
-        id: wallpaper
-        objectName: "wallpaper"
-        anchors.fill: parent
+        id: background
+        objectName: "greeterBackground"
+        anchors {
+            fill: parent
+            topMargin: backgroundTopMargin
+        }
         fillMode: Image.PreserveAspectCrop
     }
 
     // See Shell.qml's backgroundSettings treatment for why we need a separate
     // Image, but it boils down to avoiding binding loop detection.
     Image {
-        source: wallpaper.source
+        source: background.source
         height: 0
         width: 0
         sourceSize.height: 0
         sourceSize.width: 0
         onStatusChanged: {
             if (status == Image.Error && source != greeter.defaultBackground) {
-                wallpaper.source = greeter.defaultBackground
+                background.source = greeter.defaultBackground
             }
         }
     }

=== modified file 'Greeter/Lockscreen.qml'
--- Greeter/Lockscreen.qml	2013-08-14 00:01:17 +0000
+++ Greeter/Lockscreen.qml	2013-10-25 13:49:16 +0000
@@ -54,15 +54,19 @@
     }
 
     Rectangle {
-        // In case wallpaper fails to load or is undefined
-        id: wallpaperBackup
+        // In case background fails to load or is undefined
+        id: backgroundBackup
         anchors.fill: parent
         color: "black"
     }
 
     Image {
-        id: wallpaper
-        anchors.fill: parent
+        id: backgroundImage
+        objectName: "lockscreenBackground"
+        anchors {
+            fill: parent
+            topMargin: backgroundTopMargin
+        }
         source: root.required ? root.background : ""
         fillMode: Image.PreserveAspectCrop
     }

=== modified file 'Shell.qml'
--- Shell.qml	2013-10-16 15:52:38 +0000
+++ Shell.qml	2013-10-25 13:49:16 +0000
@@ -402,6 +402,10 @@
 
     Lockscreen {
         id: lockscreen
+        objectName: "lockscreen"
+
+        readonly property int backgroundTopMargin: -panel.panelHeight
+
         hides: [launcher, panel.indicators, hud]
         shown: false
         enabled: true

=== modified file 'tests/autopilot/unity8/shell/emulators/main_window.py'
--- tests/autopilot/unity8/shell/emulators/main_window.py	2013-09-24 11:54:07 +0000
+++ tests/autopilot/unity8/shell/emulators/main_window.py	2013-10-25 13:49:16 +0000
@@ -43,6 +43,9 @@
             objectName="greeterContentLoader"
         )
 
+    def get_greeter_background(self):
+        return self.app.select_single("CrossFadeImage", objectName="greeterBackground")
+
     def get_login_loader(self):
         return self.app.select_single("QQuickLoader", objectName="loginLoader")
 
@@ -93,3 +96,6 @@
 
     def get_pinentryField(self):
         return self.app.select_single(objectName="pinentryField")
+
+    def get_shell_background(self):
+        return self.app.select_single("CrossFadeImage", objectName="backgroundImage")

=== added file 'tests/autopilot/unity8/shell/tests/test_greeter.py'
--- tests/autopilot/unity8/shell/tests/test_greeter.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/unity8/shell/tests/test_greeter.py	2013-10-25 13:49:16 +0000
@@ -0,0 +1,38 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+#
+# Unity Autopilot Test Suite
+# Copyright (C) 2012-2013 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+from unity8.shell.tests import UnityTestCase, _get_device_emulation_scenarios
+
+from testtools.matchers import Equals
+
+class TestGreeter(UnityTestCase):
+
+    """Tests the Shell Greeter."""
+
+    scenarios = _get_device_emulation_scenarios()
+
+    def test_greeter_background(self):
+        """Test that the background of the greeter and the background of the shell are placed correctly
+
+        """
+        self.launch_unity()
+        self.main_window.get_greeter()
+        greeter_background = self.main_window.get_greeter_background()
+        shell_background = self.main_window.get_shell_background()
+        self.assertThat(greeter_background.globalRect, Equals(shell_background.globalRect))

=== modified file 'tests/qmltests/Greeter/tst_Phone.qml'
--- tests/qmltests/Greeter/tst_Phone.qml	2013-09-30 16:03:59 +0000
+++ tests/qmltests/Greeter/tst_Phone.qml	2013-10-25 13:49:16 +0000
@@ -120,7 +120,7 @@
             tryCompare(LightDM.Infographic, "username", "single")
         }
 
-        function test_wallpaper_data() {
+        function test_background_data() {
             return [
                 {tag: "set", accounts: "../tests/data/unity/backgrounds/blue.png", expected: "blue.png"},
                 {tag: "unset", accounts: "", expected: "background.jpg"},
@@ -128,12 +128,12 @@
             ]
         }
 
-        function test_wallpaper(data) {
+        function test_background(data) {
             var loader = findChild(greeter, "greeterContentLoader")
-            var wallpaper = findChild(loader.item, "wallpaper")
+            var background = findChild(loader.item, "greeterBackground")
             AccountsService.backgroundFile = data.accounts
-            tryCompareFunction(function() { return wallpaper.source.toString().indexOf(data.expected) !== -1; }, true)
-            tryCompare(wallpaper, "status", Image.Ready)
+            tryCompareFunction(function() { return background.source.toString().indexOf(data.expected) !== -1; }, true)
+            tryCompare(background, "status", Image.Ready)
         }
     }
 }

=== modified file 'tests/qmltests/tst_Shell.qml'
--- tests/qmltests/tst_Shell.qml	2013-10-09 20:01:12 +0000
+++ tests/qmltests/tst_Shell.qml	2013-10-25 13:49:16 +0000
@@ -432,7 +432,7 @@
             } while (!isStill);
         }
 
-        function test_wallpaper_data() {
+        function test_background_data() {
             return [
                 {tag: "red", url: "tests/data/unity/backgrounds/red.png", expectedUrl: "tests/data/unity/backgrounds/red.png"},
                 {tag: "blue", url: "tests/data/unity/backgrounds/blue.png", expectedUrl: "tests/data/unity/backgrounds/blue.png"},
@@ -441,13 +441,21 @@
             ]
         }
 
-        function test_wallpaper(data) {
+        function test_background(data) {
             var backgroundImage = findChild(shell, "backgroundImage")
             GSettingsController.setPictureUri(data.url)
             tryCompareFunction(function() { return backgroundImage.source.toString().indexOf(data.expectedUrl) !== -1; }, true)
             tryCompare(backgroundImage, "status", Image.Ready)
         }
 
+        function test_lockscreen_background() {
+            var backgroundImage = findChild(shell, "backgroundImage")
+            var lockscreen = findChild(shell, "lockscreen")
+            var lockscreenBackground = findChild(lockscreen, "lockscreenBackground")
+            var lockscreenBackgroundMapped = lockscreenBackground.mapToItem(shell, 0, 0)
+            compare(backgroundImage.y, lockscreenBackgroundMapped.y)
+        }
+
         function test_DashShown_data() {
             return [
                 {tag: "in focus", greeter: false, app: false, launcher: false, indicators: false, expectedShown: true},