Merge lp:~cimi/unity8/fix-1195349 into lp:unity8
Proposed by
Andrea Cimitan
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Albert Astals Cid | ||||
Approved revision: | 467 | ||||
Merged at revision: | 474 | ||||
Proposed branch: | lp:~cimi/unity8/fix-1195349 | ||||
Merge into: | lp:unity8 | ||||
Diff against target: |
47 lines (+5/-4) 1 file modified
Components/Carousel.qml (+5/-4) |
||||
To merge this branch: | bzr merge lp:~cimi/unity8/fix-1195349 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email: mp+191460@code.launchpad.net |
Commit message
Fix 1195349 by counting drawbuffer on the newContentX logic of the carousel
Description of the change
When we changed carousel from repeater to listview, we added drawbuffer. this breaks the logic of newContentX, which was considered disabled and set to -1. The correct disabled value now has to take into account the drawbuffer.
To post a comment you must log in.
FAILED: Continuous integration, rev:467 jenkins. qa.ubuntu. com/job/ unity8- ci/1438/ jenkins. qa.ubuntu. com/job/ generic- mediumtests- saucy/5073 jenkins. qa.ubuntu. com/job/ generic- mediumtests- touch/3013 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- saucy/2306 jenkins. qa.ubuntu. com/job/ unity8- saucy-amd64- ci/461 jenkins. qa.ubuntu. com/job/ unity8- saucy-armhf- ci/1438 jenkins. qa.ubuntu. com/job/ unity8- saucy-armhf- ci/1438/ artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity8- saucy-i386- ci/1437 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-saucy/ 1241 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-amd64/ 948 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-amd64/ 948/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 3015 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 3015/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- maguro/ 2520 jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- mako/2564 10.97.0. 26:8080/ job/touch- flash-device/ 49 10.97.0. 26:8080/ job/touch- flash-device/ 48
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: 10.97.0. 26:8080/ job/unity8- ci/1438/ rebuild
http://