Merge lp:~cimi/unity8/dashBackground_sourceSize into lp:unity8

[Andrea Cimitan]

Set sourceSize for DashBackground.qml Image

 * Are there any related MPs required for this MP to build/function as expected? Please list.
None
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
 * Did you make sure that your branch does not contain spurious tags?
Yes.
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1714
http://jenkins.qa.ubuntu.com/job/unity8-ci/5540/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2202
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/703
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/705
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/705
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1935
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2200
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2200/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19579

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5540/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

Does this actually do something?

I added

    id: moo
onImplicitWidthChanged: console.log("IW", moo, implicitWidth);
onImplicitHeightChanged: console.log("IH", moo, implicitHeight);

and seems the implicitSize is already correct, probably due to the use of the @ image provider in the SDK?

review: Needs Information

[Albert Astals Cid (aacid)]

After talking with Cimi on IRC this makes sense when the window is resized (i.e desktop case).

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass?
Our autopilot tests still needs some polishing

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

=== modified file 'qml/Dash/DashBackground.qml'
--- qml/Dash/DashBackground.qml	2014-07-15 15:39:55 +0000
+++ qml/Dash/DashBackground.qml	2015-04-13 18:31:01 +0000
@@ -21,4 +21,6 @@
     fillMode: Image.PreserveAspectCrop
     horizontalAlignment: Image.AlignRight
     verticalAlignment: Image.AlignTop
+    sourceSize.width: anchors.fill.width
+    sourceSize.height: 0
 }