Merge lp:~cimi/unity8/card-social into lp:unity8
| Status: | Superseded |
|---|---|
| Proposed branch: | lp:~cimi/unity8/card-social |
| Merge into: | lp:unity8 |
| Prerequisite: | lp:~aacid/unity8/cardCreatorFixedHeaderSizeOptimization |
| Diff against target: |
5750 lines (+3514/-919) 79 files modified
debian/control (+2/-2) plugins/Dash/CardCreator.js (+44/-1) plugins/Dash/CardSocialActions.qml (+94/-0) plugins/Dash/ScopeStyle.qml (+1/-1) plugins/Dash/qmldir (+1/-0) qml/Dash/CardGrid.qml (+1/-0) qml/Dash/CardHorizontalList.qml (+1/-0) qml/Dash/CardTool.qml (+25/-7) qml/Dash/CardVerticalJournal.qml (+1/-0) qml/Dash/DashContent.qml (+2/-2) qml/Dash/DashNavigation.qml (+170/-89) qml/Dash/DashNavigationButton.qml (+0/-233) qml/Dash/DashNavigationHeader.qml (+73/-0) qml/Dash/DashNavigationList.qml (+33/-87) qml/Dash/DashPageHeader.qml (+148/-140) qml/Dash/DashRenderer.qml (+6/-0) qml/Dash/Filters/FilterOptionSelector.qml (+91/-0) qml/Dash/Filters/FilterRangeInput.qml (+136/-0) qml/Dash/Filters/FilterValueSlider.qml (+87/-0) qml/Dash/Filters/FilterWidget.qml (+29/-0) qml/Dash/Filters/FilterWidgetFactory.qml (+79/-0) qml/Dash/FiltersPopover.qml (+105/-0) qml/Dash/GenericScopeView.qml (+81/-47) qml/Dash/PageHeaderExtraPanel.qml (+175/-0) tests/mocks/Unity/CMakeLists.txt (+14/-1) tests/mocks/Unity/fake_categories.cpp (+4/-1) tests/mocks/Unity/fake_filters.cpp (+125/-0) tests/mocks/Unity/fake_filters.h (+46/-0) tests/mocks/Unity/fake_navigation.cpp (+9/-10) tests/mocks/Unity/fake_optionselectorfilter.cpp (+65/-0) tests/mocks/Unity/fake_optionselectorfilter.h (+52/-0) tests/mocks/Unity/fake_optionselectoroptions.cpp (+77/-0) tests/mocks/Unity/fake_optionselectoroptions.h (+47/-0) tests/mocks/Unity/fake_rangeinputfilter.cpp (+167/-0) tests/mocks/Unity/fake_rangeinputfilter.h (+79/-0) tests/mocks/Unity/fake_resultsmodel.cpp (+2/-0) tests/mocks/Unity/fake_scope.cpp (+61/-36) tests/mocks/Unity/fake_scope.h (+20/-7) tests/mocks/Unity/fake_unity_plugin.cpp (+7/-0) tests/mocks/Unity/fake_valuesliderfilter.cpp (+84/-0) tests/mocks/Unity/fake_valuesliderfilter.h (+55/-0) tests/mocks/Unity/fake_valueslidervalues.cpp (+51/-0) tests/mocks/Unity/fake_valueslidervalues.h (+36/-0) tests/plugins/Dash/cardcreator/1.res (+1/-1) tests/plugins/Dash/cardcreator/1.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/10.res (+1/-1) tests/plugins/Dash/cardcreator/10.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/11.res (+1/-1) tests/plugins/Dash/cardcreator/11.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/12.res (+146/-0) tests/plugins/Dash/cardcreator/12.res.cardcreator (+145/-0) tests/plugins/Dash/cardcreator/12.tst (+3/-0) tests/plugins/Dash/cardcreator/2.res (+1/-1) tests/plugins/Dash/cardcreator/2.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/3.res (+1/-1) tests/plugins/Dash/cardcreator/3.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/4.res (+1/-1) tests/plugins/Dash/cardcreator/4.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/5.res (+1/-1) tests/plugins/Dash/cardcreator/5.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/6.res (+1/-1) tests/plugins/Dash/cardcreator/6.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/7.res (+1/-1) tests/plugins/Dash/cardcreator/7.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/8.res (+1/-1) tests/plugins/Dash/cardcreator/8.res.cardcreator (+1/-1) tests/plugins/Dash/cardcreator/9.res (+1/-1) tests/plugins/Dash/cardcreator/9.res.cardcreator (+1/-1) tests/qmltests/CMakeLists.txt (+4/-0) tests/qmltests/Dash/CardHelpers.js (+9/-7) tests/qmltests/Dash/Filters/tst_FilterOptionSelector.qml (+96/-0) tests/qmltests/Dash/Filters/tst_FilterRangeInput.qml (+247/-0) tests/qmltests/Dash/Filters/tst_FilterValueSlider.qml (+101/-0) tests/qmltests/Dash/Filters/tst_FilterWidgetFactory.qml (+57/-0) tests/qmltests/Dash/tst_Card.qml (+38/-3) tests/qmltests/Dash/tst_DashContent.qml (+234/-206) tests/qmltests/Dash/tst_DashPageHeader.qml (+24/-15) tests/qmltests/Dash/tst_GenericScopeView.qml (+1/-1) tests/qmltests/Dash/tst_PreviewView.qml (+1/-1) |
| To merge this branch: | bzr merge lp:~cimi/unity8/card-social |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | 2016-03-07 | Needs Fixing on 2016-03-21 |
| Albert Astals Cid (community) | 2016-03-07 | Needs Fixing on 2016-03-14 | |
| PS Jenkins bot | continuous-integration | 2016-03-07 | Pending |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2016-03-04.
This proposal has been superseded by a proposal from 2016-03-21.
Commit Message
Add social actions to cards
Description of the Change
* Are there any related MPs required for this MP to build/function as expected? Please list.
yes
https:/
https:/
* Did you perform an exploratory manual test run of your code change and any related functionality?
will with silo, locally tested with mocks
* Did you make sure that your branch does not contain spurious tags?
y
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
ye
* If you changed the UI, has there been a design review?
y
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2115
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Andrea Cimitan (cimi) wrote : | # |
14 gu is a small card in CardTool, minus the 1gu*2 per side.... we want
just small cards to have 4 columns
> Review: Needs Information
>
> columns: width > units.gu(12) ? 4 : 2
>
> where does this units.gu(12) come from?
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2115
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2116
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2116
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2118
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
SUCCESS: https:/
UNSTABLE: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:2118
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2119
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2120
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2120
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
None: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2122
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2123
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2127
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2127
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
The social actions won't work in a CardCarousel.
Are we OK with that?
| Paweł Stołowski (stolowski) wrote : | # |
> The social actions won't work in a CardCarousel.
>
> Are we OK with that?
Should be checked with Patricia I think.
- 2128. By Andrea Cimitan on 2016-03-07
-
Reworked one if/else
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2128
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
The socialActions contents of 12.tst don't look correct, note that that is components and for components the only thing we care about is whether it exists or not and max-count (i.e. CardTool.qml) so it needs fixing to as not to confuse people of what we expect there.
- 2129. By Andrea Cimitan on 2016-03-07
-
As review
| Andrea Cimitan (cimi) wrote : | # |
> The socialActions contents of 12.tst don't look correct, note that that is
> components and for components the only thing we care about is whether it
> exists or not and max-count (i.e. CardTool.qml) so it needs fixing to as not
> to confuse people of what we expect there.
oops fixed
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2129
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
> > The socialActions contents of 12.tst don't look correct, note that that is
> > components and for components the only thing we care about is whether it
> > exists or not and max-count (i.e. CardTool.qml) so it needs fixing to as not
> > to confuse people of what we expect there.
> oops fixed
I think there's actually the same issue in tests/mocks/
| Albert Astals Cid (aacid) wrote : | # |
> > The social actions won't work in a CardCarousel.
> >
> > Are we OK with that?
>
> Should be checked with Patricia I think.
Seems they don't want them on Carousel, so let's filter them out on the CardTool level and write a console.log if we do the filtering so that scope authors can try to figure out why it doesn't work
- 2130. By Andrea Cimitan on 2016-03-07
-
Change mocks to be more generic
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2130
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
var hasSocialActions = hasTitle && components[
needs to be social-actions
actions[
The cardLoader in CardTool needs to be like http://
You can not use
import "../../
in CardSocialActio
file://
:149:1: Type CardSocialActions unavailable
file:
| Albert Astals Cid (aacid) wrote : | # |
Text conflict in debian/control
Text conflict in qml/Dash/
Text conflict in tests/plugins/
3 conflicts encountered.
- 2131. By Andrea Cimitan on 2016-03-14
-
merge
- 2132. By Andrea Cimitan on 2016-03-21
-
Merges
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2132
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/
- 2133. By Andrea Cimitan on 2016-04-01
-
Fix for review
- 2134. By Andrea Cimitan on 2016-04-06
-
as review
- 2135. By Andrea Cimitan on 2016-05-04
-
merged trunk
- 2136. By Andrea Cimitan on 2016-05-04
-
fixed card creator test

columns: width > units.gu(12) ? 4 : 2
where does this units.gu(12) come from?