Unity

Merge lp:~cimi/unity/black-dash-layer into lp:unity

  1. black-dash-layer
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 1572
Proposed branch: lp:~cimi/unity/black-dash-layer
Merge into: lp:unity
Diff against target: 37 lines (+3/-3)
3 files modified
plugins/unityshell/src/DashView.cpp (+1/-1)
plugins/unityshell/src/Launcher.cpp (+1/-1)
plugins/unityshell/src/PanelView.cpp (+1/-1)
To merge this branch: bzr merge lp:~cimi/unity/black-dash-layer
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Review via email: mp+75624@code.launchpad.net

Description of the change

In my humble opinion the dash should be again darker. I like the work done to make it darker for unity 4.16.0, but it's still not enough *dark*.
I'm attaching few screenshot before and after a subtle modification, basically I'm using #000000 (pure black) instead #333333 (grey20), as dash background layer.

To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/DashView.cpp'
2--- plugins/unityshell/src/DashView.cpp 2011-09-15 15:56:13 +0000
3+++ plugins/unityshell/src/DashView.cpp 2011-09-15 20:03:03 +0000
4@@ -97,7 +97,7 @@
5 rop.Blend = true;
6 rop.SrcBlend = GL_SRC_COLOR;
7 rop.DstBlend = GL_DST_COLOR;
8- bg_darken_layer_ = new nux::ColorLayer(nux::Color(0.2f, 0.2f, 0.2f, 1.0f), false, rop);
9+ bg_darken_layer_ = new nux::ColorLayer(nux::Color(0.0f, 0.0f, 0.0f, 1.0f), false, rop);
10
11 bg_shine_texture_ = PlacesStyle::GetDefault()->GetDashShine()->GetDeviceTexture();
12
13
14=== modified file 'plugins/unityshell/src/Launcher.cpp'
15--- plugins/unityshell/src/Launcher.cpp 2011-09-15 14:17:34 +0000
16+++ plugins/unityshell/src/Launcher.cpp 2011-09-15 20:03:03 +0000
17@@ -2123,7 +2123,7 @@
18
19 // apply the darkening
20 GfxContext.GetRenderStates().SetBlend(true, GL_SRC_COLOR, GL_DST_COLOR);
21- gPainter.Paint2DQuadColor(GfxContext, bkg_box, nux::Color(0.2f, 0.2f, 0.2f, 1.0f));
22+ gPainter.Paint2DQuadColor(GfxContext, bkg_box, nux::Color(0.0f, 0.0f, 0.0f, 1.0f));
23 GfxContext.GetRenderStates().SetBlend (alpha, src, dest);
24
25 // apply the bg colour
26
27=== modified file 'plugins/unityshell/src/PanelView.cpp'
28--- plugins/unityshell/src/PanelView.cpp 2011-09-15 14:17:34 +0000
29+++ plugins/unityshell/src/PanelView.cpp 2011-09-15 20:03:03 +0000
30@@ -70,7 +70,7 @@
31 rop.Blend = true;
32 rop.SrcBlend = GL_SRC_COLOR;
33 rop.DstBlend = GL_DST_COLOR;
34- _bg_darken_layer_ = new nux::ColorLayer(nux::Color(0.2f, 0.2f, 0.2f, 1.0f), false, rop);
35+ _bg_darken_layer_ = new nux::ColorLayer(nux::Color(0.0f, 0.0f, 0.0f, 1.0f), false, rop);
36
37 _layout = new nux::HLayout("", NUX_TRACKER_LOCATION);
38