Merge lp:~cimi/unity-2d/unity-2d.not-recolor-workspace into lp:unity-2d

Proposed by Andrea Cimitan
Status: Merged
Approved by: Gerry Boland
Approved revision: 930
Merged at revision: 932
Proposed branch: lp:~cimi/unity-2d/unity-2d.not-recolor-workspace
Merge into: lp:unity-2d
Diff against target: 16 lines (+3/-4)
1 file modified
shell/launcher/LauncherList.qml (+3/-4)
To merge this branch: bzr merge lp:~cimi/unity-2d/unity-2d.not-recolor-workspace
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Florian Boucault (community) Approve
Review via email: mp+94349@code.launchpad.net

Description of the change

The new workspace switcher icon is white and transparent, resulting in a white tile on white icon. Do not recolor it now.
Ideally, LauncherItem.qml should colorize this icon (and BFB, and trash, and devices) using the background average color, and not by getting the icon color (Like unity 3D is doing).

To post a comment you must log in.
Revision history for this message
Florian Boucault (fboucault) wrote :

Thank you Cimi. Is there a bug report matching the MR?

review: Approve
Revision history for this message
Gerry Boland (gerboland) wrote :

I created a bug & attached it. I'm assuming as Cimi made this, then it is designer approved. Approving!
Thank you Cimi!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/launcher/LauncherList.qml'
2--- shell/launcher/LauncherList.qml 2012-02-16 11:24:19 +0000
3+++ shell/launcher/LauncherList.qml 2012-02-23 11:37:17 +0000
4@@ -139,10 +139,9 @@
5 isBeingDragged: (reorder.draggedTileId != "") && (reorder.draggedTileId == desktopFile)
6 dragPosition: reorder.listCoordinates.y - list.contentY
7
8- /* Best way I could find to check if the item is an application or the
9- workspaces switcher. There may be something cleaner and better. */
10- backgroundFromIcon: item.toString().indexOf("Application") == 0 ||
11- item.toString().indexOf("Workspaces") == 0
12+ /* Best way I could find to check if the item is an application.
13+ There may be something cleaner and better. */
14+ backgroundFromIcon: item.toString().indexOf("Application") == 0
15
16 Binding { target: item.menu; property: "title"; value: item.name }
17

Subscribers

People subscribed via source and target branches