Merge lp:~cimi/unity-2d/fix-906235 into lp:unity-2d

Proposed by Andrea Cimitan
Status: Merged
Approved by: Gerry Boland
Approved revision: 833
Merged at revision: 832
Proposed branch: lp:~cimi/unity-2d/fix-906235
Merge into: lp:unity-2d
Diff against target: 98 lines (+11/-8)
6 files modified
places/CategoryHeader.qml (+1/-1)
places/FilterCheckoption.qml (+4/-2)
places/FilterPane.qml (+2/-1)
places/TickBox.qml (+1/-1)
places/app/dashdeclarativeview.cpp (+2/-2)
places/dash.qml (+1/-1)
To merge this branch: bzr merge lp:~cimi/unity-2d/fix-906235
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+86214@code.launchpad.net

Description of the change

Some fixes to dash layout, especially on the filters pane

To post a comment you must log in.
lp:~cimi/unity-2d/fix-906235 updated
833. By Andrea Cimitan

[dash] fix dash desktop height

Revision history for this message
Gerry Boland (gerboland) wrote :

This is great, thank you!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'places/CategoryHeader.qml'
2--- places/CategoryHeader.qml 2011-12-11 16:36:28 +0000
3+++ places/CategoryHeader.qml 2011-12-19 11:04:25 +0000
4@@ -108,7 +108,7 @@
5 folded: categoryHeader.folded
6 anchors.left: label.right
7 anchors.leftMargin: 10
8- anchors.verticalCenter: label.verticalCenter
9+ anchors.bottom: label.baseline
10 }
11 }
12
13
14=== modified file 'places/FilterCheckoption.qml'
15--- places/FilterCheckoption.qml 2011-08-25 13:10:22 +0000
16+++ places/FilterCheckoption.qml 2011-12-19 11:04:25 +0000
17@@ -31,12 +31,14 @@
18 rows: Math.ceil(count/columns)
19
20 horizontalSpacing: 10
21- verticalSpacing: 12
22+ verticalSpacing: 14
23
24 cellWidth: width/columns
25 delegateHeight: 30
26
27- height: cellHeight * rows
28+ /* Substracting verticalSpacing so that the last row does
29+ not have padding below it */
30+ height: cellHeight * rows - verticalSpacing
31 boundsBehavior: Flickable.StopAtBounds
32
33 focus: true
34
35=== modified file 'places/FilterPane.qml'
36--- places/FilterPane.qml 2011-08-25 13:10:22 +0000
37+++ places/FilterPane.qml 2011-12-19 11:04:25 +0000
38@@ -82,6 +82,7 @@
39 folded: filterPane.folded
40
41 anchors.verticalCenter: title.verticalCenter
42+ anchors.verticalCenterOffset: 1
43 anchors.right: parent.right
44 }
45 }
46@@ -101,7 +102,7 @@
47 anchors.topMargin: 7
48 anchors.bottom: parent.bottom
49 orientation: ListView.Vertical
50- spacing: 12
51+ spacing: 13
52
53 /* Make sure the first section is selected when getting the focus */
54 currentIndex: 0
55
56=== modified file 'places/TickBox.qml'
57--- places/TickBox.qml 2011-08-25 13:10:22 +0000
58+++ places/TickBox.qml 2011-12-19 11:04:25 +0000
59@@ -58,7 +58,7 @@
60 else return "#21ffffff" // 80% opaque
61 border.width: ( checked ) ? 2 : 1
62 color: ( checked ) ? "#21ffffff" : "transparent"
63- radius: 5
64+ radius: 7
65 }
66
67 TextCustom {
68
69=== modified file 'places/app/dashdeclarativeview.cpp'
70--- places/app/dashdeclarativeview.cpp 2011-12-14 22:47:37 +0000
71+++ places/app/dashdeclarativeview.cpp 2011-12-19 11:04:25 +0000
72@@ -38,9 +38,9 @@
73
74 #include <config.h>
75
76-static const int DASH_DESKTOP_WIDTH = 989;
77+static const int DASH_DESKTOP_WIDTH = 996;
78 static const int DASH_DESKTOP_COLLAPSED_HEIGHT = 115;
79-static const int DASH_DESKTOP_EXPANDED_HEIGHT = 606;
80+static const int DASH_DESKTOP_EXPANDED_HEIGHT = 615;
81
82 static const char* DASH_DBUS_SERVICE = "com.canonical.Unity2d.Dash";
83 static const char* DASH_DBUS_OBJECT_PATH = "/Dash";
84
85=== modified file 'places/artwork/arrow.png'
86Binary files places/artwork/arrow.png 2011-02-13 22:11:25 +0000 and places/artwork/arrow.png 2011-12-19 11:04:25 +0000 differ
87=== modified file 'places/dash.qml'
88--- places/dash.qml 2011-12-15 11:27:51 +0000
89+++ places/dash.qml 2011-12-19 11:04:25 +0000
90@@ -243,7 +243,7 @@
91 headerHeight: search_entry.height
92 width: 300
93 anchors.right: parent.right
94- anchors.rightMargin: 8
95+ anchors.rightMargin: 15
96 }
97
98 Loader {

Subscribers

People subscribed via source and target branches