overlay-scrollbar

Merge lp:~cimi/overlay-scrollbar/unblock-thumb-callbacks into lp:overlay-scrollbar

  1. unblock-thumb-callbacks
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 164
Proposed branch: lp:~cimi/overlay-scrollbar/unblock-thumb-callbacks
Merge into: lp:overlay-scrollbar
Diff against target: 30 lines (+3/-3)
1 file modified
os/os-scrollbar.c (+3/-3)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/unblock-thumb-callbacks
Reviewer Review Type Date Requested Status
Javier Jardón Approve
Review via email: mp+53789@code.launchpad.net

Description of the change

enter,leave and motion_notify_event_cb in os-scrollbar.c were blocking vfunc in os-thumb.c because they were returning TRUE. That was affecting the rendering of the thumb.

To post a comment you must log in.
Revision history for this message
Javier Jardón (jjardon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-scrollbar.c'
2--- os/os-scrollbar.c 2011-03-16 16:17:08 +0000
3+++ os/os-scrollbar.c 2011-03-17 11:31:04 +0000
4@@ -721,7 +721,7 @@
5 priv->enter_notify_event = TRUE;
6 priv->can_hide = FALSE;
7
8- return TRUE;
9+ return FALSE;
10 }
11
12 static gboolean
13@@ -741,7 +741,7 @@
14 g_timeout_add (TIMEOUT_HIDE, os_scrollbar_hide_thumb_cb,
15 g_object_ref (scrollbar));
16
17- return TRUE;
18+ return FALSE;
19 }
20
21 static gboolean
22@@ -838,7 +838,7 @@
23 os_scrollbar_move_thumb (scrollbar, x, y);
24 }
25
26- return TRUE;
27+ return FALSE;
28 }
29
30 /* Move the pager to the right position. */

Subscribers

People subscribed via source and target branches