Merge lp:~cimi/overlay-scrollbar/show-hide-updated into lp:overlay-scrollbar

[Andrea Cimitan]

Now show/hide vfunc won't disable/enable proximity and show/hide the pager, as it was already handled by the map/unmap vfunc.
In theory, GTK_WIDGET_CLASS (os_scrollbar_parent_class)->hide/show (widget), should call gtk_widget_unmap/map (widget) which will call os_scrollbar_unmap/map (widget) only when needed, and will do the proximity and pager checks only when needed.
This should be the right approach, I've not encountered bugs so far, but if this merge will expose new bad behavior, that means we might have to fix something elsewhere.

[Loïc Molinari (loic.molinari)]

review: Approve

=== modified file 'os/os-scrollbar.c'
--- os/os-scrollbar.c	2011-03-03 17:59:02 +0000
+++ os/os-scrollbar.c	2011-03-04 16:27:08 +0000
@@ -1291,16 +1291,7 @@
 static void
 os_scrollbar_hide (GtkWidget *widget)
 {
-  OsScrollbarPrivate *priv;
-
-  priv = OS_SCROLLBAR_GET_PRIVATE (OS_SCROLLBAR (widget));
-
   GTK_WIDGET_CLASS (os_scrollbar_parent_class)->hide (widget);
-
-  priv->proximity = FALSE;
-
-  if (priv->pager != NULL)
-    os_pager_hide (OS_PAGER (priv->pager));
 }
 
 static void
@@ -1387,16 +1378,7 @@
 static void
 os_scrollbar_show (GtkWidget *widget)
 {
-  OsScrollbarPrivate *priv;
-
-  priv = OS_SCROLLBAR_GET_PRIVATE (OS_SCROLLBAR (widget));
-
   GTK_WIDGET_CLASS (os_scrollbar_parent_class)->show (widget);
-
-  priv->proximity = TRUE;
-
-  if (priv->pager != NULL)
-    os_pager_show (OS_PAGER (priv->pager));
 }
 
 static void