Merge lp:~cimi/overlay-scrollbar/protect-846562 into lp:overlay-scrollbar

[Andrea Cimitan]

Protect against 846562

[Andrea Cimitan (cimi)]

This is weird bug, I don't know if this is a correct fix for that, because the widget logically has to be realized.

In fact, on scrollbar unmap we hide the thumb. This function is called when the thumb receives a button press, so the scrollbar should not have received an unmap otherwise the click is not possible :-\ Opinions?

[Ted Gould (ted)]

The protection can't hurt... see if we still get the crash I guess.

review: Approve

=== modified file 'os/os-scrollbar.c'
--- os/os-scrollbar.c	2012-03-21 13:44:55 +0000
+++ os/os-scrollbar.c	2012-04-02 11:43:18 +0000
@@ -1561,9 +1561,12 @@
 present_gdk_window_with_timestamp (GtkWidget *widget,
                                    guint32    timestamp)
 {
-  present_window_with_timestamp (GDK_SCREEN_XSCREEN (gtk_widget_get_screen (widget)),
-                                 GDK_WINDOW_XID (gtk_widget_get_window (widget)),
-                                 timestamp);
+  /* Check if the widget is realized, to protect against:
+   * https://bugs.launchpad.net/ayatana-scrollbar/+bug/846562 */
+  if (gtk_widget_get_realized (widget))
+    present_window_with_timestamp (GDK_SCREEN_XSCREEN (gtk_widget_get_screen (widget)),
+                                   GDK_WINDOW_XID (gtk_widget_get_window (widget)),
+                                   timestamp);
 }
 
 static gboolean