overlay-scrollbar

Merge lp:~cimi/overlay-scrollbar/not-move-thumb-on-configure into lp:overlay-scrollbar

  1. not-move-thumb-on-configure
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 166
Proposed branch: lp:~cimi/overlay-scrollbar/not-move-thumb-on-configure
Merge into: lp:overlay-scrollbar
Diff against target: 14 lines (+0/-4)
1 file modified
os/os-scrollbar.c (+0/-4)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/not-move-thumb-on-configure
Reviewer Review Type Date Requested Status
Javier Jardón Approve
Review via email: mp+53884@code.launchpad.net

Description of the change

I can't see any reason why we should move the thumb in the configure event, as now everything in handled in toplevel_filter_func. Please test it, but should be totally safe

To post a comment you must log in.
Revision history for this message
Javier Jardón (jjardon) wrote :

Works ok here too

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-scrollbar.c'
2--- os/os-scrollbar.c 2011-03-17 11:27:08 +0000
3+++ os/os-scrollbar.c 2011-03-17 19:27:26 +0000
4@@ -1066,10 +1066,6 @@
5 os_scrollbar_calc_layout_pager (scrollbar, priv->adjustment->value);
6 os_scrollbar_calc_layout_slider (scrollbar, priv->adjustment->value);
7
8- os_scrollbar_move_thumb (scrollbar,
9- event->x + priv->thumb_all.x + priv->slider.x,
10- event->y + priv->thumb_all.y + priv->slider.y);
11-
12 os_scrollbar_store_window_position (scrollbar);
13
14 return FALSE;

Subscribers

People subscribed via source and target branches