overlay-scrollbar

Merge lp:~cimi/overlay-scrollbar/new-fix-735867 into lp:overlay-scrollbar

  1. new-fix-735867
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 234
Proposed branch: lp:~cimi/overlay-scrollbar/new-fix-735867
Merge into: lp:overlay-scrollbar
Diff against target: 21 lines (+2/-2)
1 file modified
os/os-scrollbar.c (+2/-2)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/new-fix-735867
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+60880@code.launchpad.net

Description of the change

priv->overlay.y == 0 could break some cases, where the movement is slow enough to trigger the movement of the overlay. let's check for the adjustment value

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-scrollbar.c'
2--- os/os-scrollbar.c 2011-05-08 14:06:01 +0000
3+++ os/os-scrollbar.c 2011-05-13 09:58:53 +0000
4@@ -965,7 +965,7 @@
5 priv->win_y + priv->overlay.y,
6 priv->win_y + priv->overlay.y + priv->overlay.height - priv->slider.height);
7
8- if (priv->overlay.y == 0)
9+ if (priv->adjustment->value == 0)
10 {
11 priv->slide_initial_slider_position = 0;
12 priv->slide_initial_coordinate = MAX (event->y_root, priv->win_y + priv->pointer_y);
13@@ -991,7 +991,7 @@
14 priv->win_x + priv->overlay.x + priv->overlay.width - priv->slider.width);
15 y = priv->win_y;
16
17- if (priv->overlay.x == 0)
18+ if (priv->adjustment->value == 0)
19 {
20 priv->slide_initial_slider_position = 0;
21 priv->slide_initial_coordinate = MAX (event->x_root, priv->win_x + priv->pointer_x);

Subscribers

People subscribed via source and target branches