Merge lp:~cimi/overlay-scrollbar/hide-at-full-size-pager into lp:overlay-scrollbar

[Andrea Cimitan]

This should hide the scrollbar correctly when the scrolling disappears (no content to scroll).
I'm not in love with the approach of this branch, because I should supervisor when os_pager_show and os_pager_hide are called by both map()/unmap() and adjustment_changed_cb() (I don't want to see pagers reappearing because of a change in the adjustment of an invisible pager).
Indeed, right now it seems to work.
I would propose a saner control over those calls in the future.

[Loïc Molinari (loic.molinari)]

Looks good to me.

I'd put a "FIXME(Cimi): " in adjustment_changed_cb() explaining the pros and cons, like you did in that merge request. That way, your thoughts can be shared with people reading the code and won't be lost in that merge request.

[lp:~cimi/overlay-scrollbar/hide-at-full-size-pager]

143. By Andrea Cimitan on 2011-03-07

Added a FIXME to keep track of my concern

144. By Andrea Cimitan on 2011-03-07

updated fixme

[Loïc Molinari (loic.molinari)]

review: Approve

[lp:~cimi/overlay-scrollbar/hide-at-full-size-pager]

145. By Andrea Cimitan on 2011-03-07

updated fixme