Merge lp:~cimi/overlay-scrollbar/gtk-destroy-widget-on-swap-thumb into lp:overlay-scrollbar

Proposed by Andrea Cimitan
Status: Merged
Merged at revision: 179
Proposed branch: lp:~cimi/overlay-scrollbar/gtk-destroy-widget-on-swap-thumb
Merge into: lp:overlay-scrollbar
Diff against target: 11 lines (+2/-0)
1 file modified
os/os-scrollbar.c (+2/-0)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/gtk-destroy-widget-on-swap-thumb
Reviewer Review Type Date Requested Status
Loïc Molinari (community) Approve
Review via email: mp+55250@code.launchpad.net

Description of the change

the thumb was never destroyed, because the gtkwindow is referencing the gobject at gtk_window_init. so call gtk_widget_destroy when swapping the thumb

To post a comment you must log in.
Revision history for this message
Loïc Molinari (loic.molinari) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-scrollbar.c'
2--- os/os-scrollbar.c 2011-03-28 17:42:42 +0000
3+++ os/os-scrollbar.c 2011-03-28 22:42:31 +0000
4@@ -585,6 +585,8 @@
5 g_signal_handlers_disconnect_by_func (G_OBJECT (priv->thumb),
6 thumb_unmap_cb, scrollbar);
7
8+ gtk_widget_destroy (priv->thumb);
9+
10 g_object_unref (priv->thumb);
11 }
12

Subscribers

People subscribed via source and target branches