overlay-scrollbar

Merge lp:~cimi/overlay-scrollbar/fix-uwd into lp:overlay-scrollbar

  1. fix-uwd
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Approved by: Ted Gould
Approved revision: 187
Merged at revision: 186
Proposed branch: lp:~cimi/overlay-scrollbar/fix-uwd
Merge into: lp:overlay-scrollbar
Diff against target: 13 lines (+2/-1)
1 file modified
os/os-scrollbar.c (+2/-1)
To merge this branch: bzr merge lp:~cimi/overlay-scrollbar/fix-uwd
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+55922@code.launchpad.net

Description of the change

uwd was calling a configure event when focusing the window, that's why we had this gtk_widget_hide on the thumb

To post a comment you must log in.
lp:~cimi/overlay-scrollbar/fix-uwd updated
187. By Andrea Cimitan

maybe enter_notify_event is enough. let's do the minimum, then fix bugs if they occur by adding !priv->button_press_event too

Revision history for this message
Ted Gould (ted) wrote :

  review approve
  merge approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'os/os-scrollbar.c'
2--- os/os-scrollbar.c 2011-03-31 14:52:02 +0000
3+++ os/os-scrollbar.c 2011-04-01 12:59:31 +0000
4@@ -999,7 +999,8 @@
5 scrollbar = OS_SCROLLBAR (user_data);
6 priv = scrollbar->priv;
7
8- gtk_widget_hide (GTK_WIDGET (priv->thumb));
9+ if (!priv->enter_notify_event)
10+ gtk_widget_hide (GTK_WIDGET (priv->thumb));
11
12 os_scrollbar_calc_layout_pager (scrollbar, priv->adjustment->value);
13 os_scrollbar_calc_layout_slider (scrollbar, priv->adjustment->value);

Subscribers

People subscribed via source and target branches