The Avila project

Merge ~chunsang/avila/+git/kernel-3.10:power_consumption/fix-kworker-auto-brightness into ~phablet-team/avila/+git/kernel-3.10:ubuntu

  1. Git
  2. lp:~chunsang/avila/+git/kernel-3.10
  3. power_consumption/fix-kworker-auto-brightness
  4. Merge into ubuntu
Proposed by Chunsang Jeong
Status: Merged
Approved by: Alfonso Sanchez-Beato
Approved revision: aea9975a655c946abf2303492d504640815b1c11
Merged at revision: aea9975a655c946abf2303492d504640815b1c11
Proposed branch: ~chunsang/avila/+git/kernel-3.10:power_consumption/fix-kworker-auto-brightness
Merge into: ~phablet-team/avila/+git/kernel-3.10:ubuntu
Diff against target: 13 lines (+1/-1)
1 file modified
drivers/misc/mediatek/alsps/alsps.c (+1/-1)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato Approve
Ubuntu Phablet Team Pending
Review via email: mp+293057@code.launchpad.net

Description of the change

Fix kworker process polling interval

This will change als polling interval to 1000ms from 1ms. kworker process
previously used 17% CPU when autobrightness was turned on, meanwhile auto
brightness works with thousands of ms based.

Bug: https://bugs.launchpad.net/avila/+bug/1573469

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/drivers/misc/mediatek/alsps/alsps.c b/drivers/misc/mediatek/alsps/alsps.c
2index 7cf9d62..d1c591a 100644
3--- a/drivers/misc/mediatek/alsps/alsps.c
4+++ b/drivers/misc/mediatek/alsps/alsps.c
5@@ -491,7 +491,7 @@ static ssize_t als_store_delay(struct device* dev, struct device_attribute *attr
6
7 if(false == cxt->als_ctl.is_report_input_direct)
8 {
9- mdelay = (int)delay/1000/1000;
10+ mdelay = (int)delay/1000;
11 atomic_set(&alsps_context_obj->delay_als, mdelay);
12 }
13 cxt->als_ctl.set_delay(delay);

Subscribers

People subscribed via source and target branches