Merge lp:~chromakode/boots/postgresql into lp:boots
Status: | Needs review |
---|---|
Proposed branch: | lp:~chromakode/boots/postgresql |
Merge into: | lp:boots |
Diff against target: |
319 lines (+98/-32) 8 files modified
boots/api/constructors.py (+1/-1) boots/api/errors.py (+4/-1) boots/api/server.py (+59/-7) boots/lib/console.py (+3/-3) boots/lib/ui/plain.py (+16/-6) tests/boots/api/server_tests.py (+12/-11) tests/boots/boots_unit_test.py (+1/-1) tests/boots/tests.py (+2/-2) |
To merge this branch: | bzr merge lp:~chromakode/boots/postgresql |
Related bugs: | |
Related blueprints: |
PostgreSQL Support
(High)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Boots Developers | Pending | ||
Review via email: mp+22358@code.launchpad.net |
Description of the change
Initial PostgreSQL support added. Table output is wonky, because psycopg2 does not calculate display_size for columns, so we'd need to calculate the maximum sizes ourselves.
We can merge this code now, but it won't be very useful until DSN support lands, or the user is able to specify the server type some other way.
In a future patch, we should probably update gen_table() in plain.py to calculate the display size if the value we got is None.
Unmerged revisions
- 164. By Max Goodhart
-
Stylistic improvement to query code for PostgreSQL server_version.
- 163. By Max Goodhart
-
Add slow manual display_size calculation in output ascii table generation, in case display_size is not provided by the database driver.
- 162. By Max Goodhart
-
Initial internal PostgreSQL support, with the required tweaks and fixes.
- 161. By Max Goodhart
-
Refactor boots.api.api into boots.api.server.
And there's display_size calculation in gen_table(). Now PostgreSQL connections should be pretty indistinguishable from other connections.