Merge lp:~christou08/pantheon-greeter/fix-startup-animation into lp:~elementary-pantheon/pantheon-greeter/trunk

Proposed by Christian Kemgang
Status: Merged
Merged at revision: 310
Proposed branch: lp:~christou08/pantheon-greeter/fix-startup-animation
Merge into: lp:~elementary-pantheon/pantheon-greeter/trunk
Diff against target: 19 lines (+2/-2)
1 file modified
src/PantheonGreeter.vala (+2/-2)
To merge this branch: bzr merge lp:~christou08/pantheon-greeter/fix-startup-animation
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Danielle Foré design Pending
Review via email: mp+221859@code.launchpad.net

Description of the change

I made the startup animation shorter.

To post a comment you must log in.
Revision history for this message
Raphael Isemann (teemperor) wrote :

Code works, is it ok Daniel?

(Chris is working with me, so he knows that you wanted a 200ms-crossfade).

Revision history for this message
Danielle Foré (danrabbit) wrote :

Hm, well the actual avatar moving animation is much longer than the wallpaper coming in, which is kinda weird. All the animations should probably be the same length

Revision history for this message
Cody Garver (codygarver) wrote :

Dan said animations should be same duration

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/PantheonGreeter.vala'
2--- src/PantheonGreeter.vala 2014-03-13 21:16:43 +0000
3+++ src/PantheonGreeter.vala 2014-06-03 10:55:43 +0000
4@@ -122,7 +122,7 @@
5 add (clutter);
6 show_all ();
7
8- greeterbox.animate (Clutter.AnimationMode.EASE_OUT_QUART, 1700, opacity: 255);
9+ greeterbox.animate (Clutter.AnimationMode.EASE_OUT_QUART, 200, opacity: 255);
10
11 var last_user = settings.get_string ("last-user");
12 for (var i = 0; i < userlist.size; i++) {
13@@ -260,4 +260,4 @@
14 Gtk.main ();
15
16 return Posix.EXIT_SUCCESS;
17-}
18+}
19\ No newline at end of file

Subscribers

People subscribed via source and target branches