Merge lp:~christophe-lyon/gcc-linaro/4.7-backport-vect-cost-model into lp:gcc-linaro/4.7

Proposed by Christophe Lyon on 2013-04-02
Status: Merged
Approved by: Yvan Roux on 2013-04-03
Approved revision: no longer in the source branch.
Merge reported by: Yvan Roux
Merged at revision: not available
Proposed branch: lp:~christophe-lyon/gcc-linaro/4.7-backport-vect-cost-model
Merge into: lp:gcc-linaro/4.7
To merge this branch: bzr merge lp:~christophe-lyon/gcc-linaro/4.7-backport-vect-cost-model
Reviewer Review Type Date Requested Status
Yvan Roux 2013-04-02 Approve on 2013-04-02
Christophe Lyon Pending
Review via email: mp+156537@code.launchpad.net

This proposal supersedes a proposal from 2013-02-22.

Description of the change

Backport of the vectorizer cost model, from gcc-trunk.
Currently for benchmarking on our 4.7 branch.

[2013-04-02]
Bench results are avaiable at:
http://cbuild.validation.linaro.org/benchmarks/gcc-linaro-4.7%2bbzr115060~christophe-lyon~4.7-backport-vect-cost-model/logs/

No significant difference, as expected.

The build results are at:
http://cbuild.validation.linaro.org/build/gcc-linaro-4.7%2bbzr115060~christophe-lyon~4.7-backport-vect-cost-model/logs/

[2013-04-02]
Fix Changelog.linaro.

To post a comment you must log in.
Linaro Toolchain Builder (cbuild) wrote : Posted in a previous version of this proposal

cbuild has taken a snapshot of this branch at r115060 and queued it for build.

The diff against the ancestor r115058 is available at:
 http://cbuild.validation.linaro.org/snapshots/gcc-linaro-4.7+bzr115060~christophe-lyon~4.7-backport-vect-cost-model.diff

and will be built on the following builders:
 a9-builder a9hf-builder armv5-builder i686 x86_64 xaarch64 xaarch64_bare xcortexa15hf

You can track the build queue at:
 http://cbuild.validation.linaro.org/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr115060~christophe-lyon~4.7-backport-vect-cost-model
cbuild-ancestor: lp:gcc-linaro+bzr115058
cbuild-state: check

Christophe Lyon (christophe-lyon) : Posted in a previous version of this proposal
review: Resubmit
Yvan Roux (yvan-roux) wrote : Posted in a previous version of this proposal

Do you know why gcc.c-torture/compile/bcopy-1.c moved from FAIL to PASS on i686 after this backport ?

Christophe Lyon (christophe-lyon) wrote : Posted in a previous version of this proposal

> Do you know why gcc.c-torture/compile/bcopy-1.c moved from FAIL to PASS on
> i686 after this backport ?

No. The changes I introduced are ARM-only.

Maybe another of these x86 tests with varying results we observe sometimes?

Yvan Roux (yvan-roux) wrote : Posted in a previous version of this proposal

* Diff matches upstream, but Changelog.linaro doesn't include the removing of the unrelevant 4.8 code:
  - removing of arm_add_stmt_cost, TARGET_VECTORIZE_ADD_STMT_COST and the handling of the enum vect_cost_for_stmt value vec_construct in arm_builtin_vectorization_cost.

* testsuite is fine (with the usual qemu threading issues on cortexa9hf and cortexa15hf)
* benchmarks are ok

Yvan Roux (yvan-roux) wrote : Posted in a previous version of this proposal

Oups, for cortexa9hf it is not qemu related, but we have some changes in thread simulation tests :

-UNSUPPORTED: gcc.dg/simulate-thread/atomic-load-int.c -O2 -g thread simulation test
+PASS: gcc.dg/simulate-thread/atomic-load-int.c -O2 -g thread simulation test
-PASS: gcc.dg/simulate-thread/atomic-load-longlong.c -O0 -g thread simulation test
+UNSUPPORTED: gcc.dg/simulate-thread/atomic-load-longlong.c -O0 -g thread simulation test

Yvan Roux (yvan-roux) : Posted in a previous version of this proposal
review: Needs Fixing
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r115061 and queued it for build.

The diff against the ancestor r115058 is available at:
 http://cbuild.validation.linaro.org/snapshots/gcc-linaro-4.7+bzr115061~christophe-lyon~4.7-backport-vect-cost-model.diff

and will be built on the following builders:
 a9-builder a9hf-builder armv5-builder i686 x86_64 xaarch64 xaarch64_bare xcortexa15hf

You can track the build queue at:
 http://cbuild.validation.linaro.org/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.7+bzr115061~christophe-lyon~4.7-backport-vect-cost-model
cbuild-ancestor: lp:gcc-linaro+bzr115058
cbuild-state: check

Yvan Roux (yvan-roux) wrote :

Approved as the changes are only in the Changelog.

review: Approve

Diff calculation failed

Calculating the branch diff failed. You can manually schedule an update if required.

Subscribers

People subscribed via source and target branches