Merge ~chrissharp123/launchpad:lp28649_fix_emails_breaking_urls_with_hyphens into launchpad:master

Proposed by Chris Sharp
Status: Needs review
Proposed branch: ~chrissharp123/launchpad:lp28649_fix_emails_breaking_urls_with_hyphens
Merge into: launchpad:master
Diff against target: 12 lines (+1/-0)
1 file modified
lib/lp/services/mail/mailwrapper.py (+1/-0)
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+495567@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Clinton Fung (clinton-fung) wrote :

Thank you for this contribution, Chris. Would you be open to writing some tests for this scenario?

Revision history for this message
Chris Sharp (chrissharp123) wrote :

Happy to give it a go. I'm looking at standard_yuixhr_test_template.py - is that the best place to start?

Revision history for this message
Clinton Fung (clinton-fung) wrote :

Unmerged commits

c33fb8f... by Chris Sharp

LP#28649: Stop breaking URLs in bug mail

Signed-off-by: Chris Sharp <email address hidden>

Succeeded
[SUCCEEDED] lint:0 (build)
[SUCCEEDED] mypy:0 (build)
12 of 2 results

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/services/mail/mailwrapper.py b/lib/lp/services/mail/mailwrapper.py
2index 21eef18..7cad371 100644
3--- a/lib/lp/services/mail/mailwrapper.py
4+++ b/lib/lp/services/mail/mailwrapper.py
5@@ -32,6 +32,7 @@ class MailWrapper:
6 subsequent_indent=indent,
7 replace_whitespace=False,
8 break_long_words=False,
9+ break_on_hyphens=False,
10 )
11
12 def format(self, text, force_wrap=False, wrap_func=None):

Subscribers

People subscribed via source and target branches

to status/vote changes: