Merge lp:~chrismcginlay/ubuntu/natty/ubuntuone-control-panel/ubuntuone-control-panel-fix-715820 into lp:ubuntu/natty/ubuntuone-control-panel

Proposed by Chris McGinlay
Status: Rejected
Rejected by: dobey
Proposed branch: lp:~chrismcginlay/ubuntu/natty/ubuntuone-control-panel/ubuntuone-control-panel-fix-715820
Merge into: lp:ubuntu/natty/ubuntuone-control-panel
Diff against target: 98 lines (+25/-1)
2 files modified
debian/changelog (+9/-0)
ubuntuone/controlpanel/gtk/gui.py (+16/-1)
To merge this branch: bzr merge lp:~chrismcginlay/ubuntu/natty/ubuntuone-control-panel/ubuntuone-control-panel-fix-715820
Reviewer Review Type Date Requested Status
Natalia Bidart Disapprove
Ubuntu Sponsors Team Pending
Review via email: mp+49743@code.launchpad.net

Description of the change

  * controlpanel/gtk/gui.py
    - Implement tooltips for Connect/Disconnect and Account/Cloud/Devices (LP: #715820)
    - Modified _update_status(), adding tooltip=None argument after callback argument
    - Modified ManagementPanel.__init__(), using set_tooltip_text().

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Hi Chris,

like I mentioned in the linked bug report, you should be building and proposing this branch against the project instead of the source package.

Also, all the UI and non-UI changes (except extremely trivial ones) should have its matching test suite proving the changes correctness.

And last but not least, we're not adding new strings to the UI without our product owner approval. About this, I will talk to him asking for review or re-wording of the added tooltips.

Summing up, I'll be disapproving this proposal but looking forward to see a new one with the things I mentioned above. Thanks!

review: Disapprove

Unmerged revisions

13. By Chris McGinlay

* controlpanel/gtk/gui.py
  - Implement tooltips for Connect/Disconnect and Account/Cloud/Devices (LP: #715820)
  - Modified _update_status(), adding tooltip=None argument after callback argument
  - Modified ManagementPanel.__init__(), using set_tooltip_text().

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-02-12 03:18:15 +0000
3+++ debian/changelog 2011-02-15 00:47:53 +0000
4@@ -1,3 +1,12 @@
5+ubuntuone-control-panel (0.8.3-0ubuntu2) natty; urgency=low
6+
7+ * controlpanel/gtk/gui.py
8+ - Implement tooltips for Connect/Disconnect and Account/Cloud/Devices (LP: #715820)
9+ - Modified _update_status(), adding tooltip=None argument after callback argument
10+ - Modified ManagementPanel.__init__(), using set_tooltip_text().
11+
12+ -- Chris McGinlay <chris@ascentsoftware.org.uk> Tue, 15 Feb 2011 00:28:23 +0000
13+
14 ubuntuone-control-panel (0.8.3-0ubuntu1) natty; urgency=low
15
16 * New upstream release.
17
18=== modified file 'ubuntuone/controlpanel/gtk/gui.py'
19--- ubuntuone/controlpanel/gtk/gui.py 2011-02-12 03:07:22 +0000
20+++ ubuntuone/controlpanel/gtk/gui.py 2011-02-15 00:47:53 +0000
21@@ -1112,6 +1112,9 @@
22 START = _('Start')
23 STOP = _('Stop')
24
25+ CONNECT_TOOLTIP = _('Connect this computer to Ubuntu One service')
26+ DISCONNECT_TOOLTIP = _('Disconnect this computer from Ubuntu One service')
27+
28 def __init__(self):
29 gtk.HBox.__init__(self)
30 ControlPanelMixin.__init__(self)
31@@ -1144,7 +1147,7 @@
32 error_handler=error_handler)
33 self.show_all()
34
35- def _update_status(self, msg, action, callback, icon=None, color=None):
36+ def _update_status(self, msg, action, callback, tooltip=None, icon=None, color=None):
37 """Update the status info."""
38 if icon is not None:
39 foreground = '' if color is None else 'foreground="%s"' % color
40@@ -1156,6 +1159,8 @@
41 self.button.set_uri(action)
42 self.button.set_sensitive(True)
43 self.button.set_data('callback', callback)
44+ if tooltip is not None:
45+ self.button.set_tooltip_text(tooltip)
46
47 def _on_button_clicked(self, button):
48 """Button was clicked, act accordingly the label."""
49@@ -1189,6 +1194,7 @@
50 """Backend notifies of file sync status being ready."""
51 self._update_status(self.FILE_SYNC_DISCONNECTED,
52 self.CONNECT, self.on_connect_clicked,
53+ self.CONNECT_TOOLTIP,
54 '✘', 'red')
55
56 @log_call(logger.info)
57@@ -1196,6 +1202,7 @@
58 """Backend notifies of file sync status being syncing."""
59 self._update_status(self.FILE_SYNC_SYNCING,
60 self.DISCONNECT, self.on_disconnect_clicked,
61+ self.DISCONNECT_TOOLTIP,
62 '⇅', ORANGE)
63
64 @log_call(logger.info)
65@@ -1203,6 +1210,7 @@
66 """Backend notifies of file sync status being idle."""
67 self._update_status(self.FILE_SYNC_IDLE,
68 self.DISCONNECT, self.on_disconnect_clicked,
69+ self.DISCONNECT_TOOLTIP,
70 '✔', 'green')
71
72 @log_call(logger.error)
73@@ -1264,6 +1272,10 @@
74 QUOTA_LABEL = _('%(used)s used of %(total)s (%(percentage).1f%%)')
75 DASHBOARD_BUTTON_NAME = 'Account'
76 DEVICES_BUTTON_NAME = 'Devices'
77+ DASHBOARD_BUTTON_TOOLTIP = _('Your personal details and service summary')
78+ DEVICES_BUTTON_TOOLTIP = _('View, limit or remove devices that can '
79+ 'connect to your personal cloud')
80+ VOLUMES_BUTTON_TOOLTIP = _('Control which cloud folders to sync')
81
82 def __init__(self, main_window=None):
83 gtk.VBox.__init__(self)
84@@ -1305,11 +1317,14 @@
85 self.notebook.insert_page(getattr(self, tab), position=page_num)
86
87 self.dashboard_button.set_name(self.DASHBOARD_BUTTON_NAME)
88+ self.dashboard_button.set_tooltip_text(self.DASHBOARD_BUTTON_TOOLTIP)
89
90 self.volumes_button.connect('clicked', lambda b: self.volumes.load())
91 self.services_button.connect('clicked', lambda b: self.services.load())
92+ self.volumes_button.set_tooltip_text(self.VOLUMES_BUTTON_TOOLTIP)
93
94 self.devices_button.set_name(self.DEVICES_BUTTON_NAME)
95+ self.devices_button.set_tooltip_text(self.DEVICES_BUTTON_TOOLTIP)
96 self.devices_button.connect('clicked', lambda b: self.devices.load())
97 self.devices.connect('local-device-removed',
98 lambda widget: self.emit('local-device-removed'))

Subscribers

People subscribed via source and target branches