Merge lp:~chrismcginlay/ubuntu/natty/ubuntuone-control-panel/ubuntuone-control-panel-fix-715820 into lp:ubuntu/natty/ubuntuone-control-panel
Proposed by
Chris McGinlay
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | dobey | ||||
Proposed branch: | lp:~chrismcginlay/ubuntu/natty/ubuntuone-control-panel/ubuntuone-control-panel-fix-715820 | ||||
Merge into: | lp:ubuntu/natty/ubuntuone-control-panel | ||||
Diff against target: |
98 lines (+25/-1) 2 files modified
debian/changelog (+9/-0) ubuntuone/controlpanel/gtk/gui.py (+16/-1) |
||||
To merge this branch: | bzr merge lp:~chrismcginlay/ubuntu/natty/ubuntuone-control-panel/ubuntuone-control-panel-fix-715820 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Natalia Bidart | Disapprove | ||
Ubuntu Sponsors | Pending | ||
Review via email: mp+49743@code.launchpad.net |
Description of the change
* controlpanel/
- Implement tooltips for Connect/Disconnect and Account/
- Modified _update_status(), adding tooltip=None argument after callback argument
- Modified ManagementPanel
To post a comment you must log in.
Unmerged revisions
- 13. By Chris McGinlay
-
* controlpanel/
gtk/gui. py
- Implement tooltips for Connect/Disconnect and Account/Cloud/Devices (LP: #715820)
- Modified _update_status(), adding tooltip=None argument after callback argument
- Modified ManagementPanel.__init_ _(), using set_tooltip_text().
Hi Chris,
like I mentioned in the linked bug report, you should be building and proposing this branch against the project instead of the source package.
Also, all the UI and non-UI changes (except extremely trivial ones) should have its matching test suite proving the changes correctness.
And last but not least, we're not adding new strings to the UI without our product owner approval. About this, I will talk to him asking for review or re-wording of the added tooltips.
Summing up, I'll be disapproving this proposal but looking forward to see a new one with the things I mentioned above. Thanks!