lp:~chrisccoulson/unity-firefox-extension/lp1076350

Branch merges

Merged into lp:unity-firefox-extension at revision 349

Maxim Ermilov (community): Approve on 2012-11-22

Diff: 54 lines (+17/-7)

1 file modified

unity-firefox-extension/content/unity-global-property-initializer.js (+17/-7)

api

Propose for merging

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

351. By Chris Coulson on 2012-11-22

Only disconnect from the pagehide handler when the window is destroyed. This fixes a case where navigating to another window then back again, and then using the Unity API will prevent the context from being destroyed on the next page navigation or when the tab is destroyed

350. By Chris Coulson on 2012-11-22

UnityObject's are currently stored in a weak map, keyed by outer window (which comes from the "content-document\-global\-created" notification). Outer window's are reused between page navigations across domains. Each UnityObject disconnects from the documents pagehide notification when a window navigates to another document the first time, so if a subsequent document uses the Unity API, it will never clean up the corresponding context when the tab is closed (and the outer window disappears). Instead, UnityObject's should be keyed by some object tied to the *inner* window (the inner window isn't directly accessible, but there are some objects that are tied to the inner window, such as window.navigator). Although, if UnityObject is tied to the lifetime of an inner window, I wonder why UnityObjectFactory exists at all....

349. By Launchpad Translations on behalf of webapps on 2012-11-21

Launchpad automatic translations update.

348. By Maxim Ermilov on 2012-11-20

listen for tabClose event

347. By Launchpad Translations on behalf of webapps on 2012-11-20

Launchpad automatic translations update.

346. By Maxim Ermilov on 2012-11-19

bump version

345. By Maxim Ermilov on 2012-11-19

import translations

344. By Maxim Ermilov on 2012-11-15

more strings for translations

343. By Launchpad Translations on behalf of webapps on 2012-11-18

Launchpad automatic translations update.

342. By Launchpad Translations on behalf of webapps on 2012-11-17

Launchpad automatic translations update.