Merge lp:~chrisccoulson/ubuntuone-client/lp767825 into lp:ubuntuone-client

Proposed by Chris Coulson
Status: Merged
Approved by: dobey
Approved revision: 964
Merged at revision: 965
Proposed branch: lp:~chrisccoulson/ubuntuone-client/lp767825
Merge into: lp:ubuntuone-client
Diff against target: 20 lines (+4/-4)
1 file modified
nautilus/utils.c (+4/-4)
To merge this branch: bzr merge lp:~chrisccoulson/ubuntuone-client/lp767825
Reviewer Review Type Date Requested Status
dobey (community) Approve
Roman Yepishev (community) fieldtest Approve
Review via email: mp+58594@code.launchpad.net

Commit message

Don't try to free a GConfValue where the value doesn't exist

Description of the change

Don't try to free a GConfValue where the value doesn't exist. Fixes errors been logged to ~/.xsession-errors

To post a comment you must log in.
Revision history for this message
Roman Yepishev (rye) wrote :

After the patch is applied there are no more "gconf_value_free: assertion" messages.

review: Approve (fieldtest)
Revision history for this message
dobey (dobey) wrote :

Looks ok to me, though the addition of the {} before the else are unnecessary.

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

There was a problem validating some authors of the branch. Authors must be either one of the listed Launchpad users, or a member of one of the listed teams on Launchpad.

Persons or Teams:

    contributor-agreement-canonical
    ubuntuone-hackers

Unaccepted Authors:

    Chris Coulson <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nautilus/utils.c'
2--- nautilus/utils.c 2011-02-11 15:24:48 +0000
3+++ nautilus/utils.c 2011-04-20 22:57:30 +0000
4@@ -176,12 +176,12 @@
5 show_location_value = gconf_client_get (conf_client, EXPANDER_SHOWN_KEY, NULL);
6 g_object_unref (conf_client);
7
8- if (show_location_value == NULL)
9+ if (show_location_value == NULL) {
10 show_location = TRUE;
11- else
12+ } else {
13 show_location = gconf_value_get_bool (show_location_value);
14-
15- gconf_value_free (show_location_value);
16+ gconf_value_free (show_location_value);
17+ }
18
19 return show_location;
20 }

Subscribers

People subscribed via source and target branches