Merge lp:~chrisccoulson/qtubuntu/lp1278470 into lp:qtubuntu

Proposed by Chris Coulson
Status: Merged
Approved by: Loïc Molinari
Approved revision: 205
Merged at revision: 211
Proposed branch: lp:~chrisccoulson/qtubuntu/lp1278470
Merge into: lp:qtubuntu
Diff against target: 52 lines (+9/-4)
3 files modified
src/platforms/base/context.cc (+4/-2)
src/platforms/base/context.h (+2/-1)
src/platforms/base/integration.cc (+3/-1)
To merge this branch: bzr merge lp:~chrisccoulson/qtubuntu/lp1278470
Reviewer Review Type Date Requested Status
Loïc Molinari (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+205609@code.launchpad.net

Commit message

Pass the EGL share context to eglCreateContext (lp: #1278470)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:205
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~chrisccoulson/qtubuntu/lp1278470/+merge/205609/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/qtubuntu-ci/113/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/24
        deb: http://jenkins.qa.ubuntu.com/job/qtubuntu-trusty-armhf-ci/24/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtubuntu-ci/113/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Nice job!

review: Approve
lp:~chrisccoulson/qtubuntu/lp1278470 updated
206. By Chris Coulson

Merge from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/platforms/base/context.cc'
2--- src/platforms/base/context.cc 2014-01-31 00:02:16 +0000
3+++ src/platforms/base/context.cc 2014-03-18 16:39:15 +0000
4@@ -46,7 +46,8 @@
5 #endif
6 }
7
8-QUbuntuBaseContext::QUbuntuBaseContext(QUbuntuBaseScreen* screen) {
9+QUbuntuBaseContext::QUbuntuBaseContext(QUbuntuBaseScreen* screen,
10+ QUbuntuBaseContext* share) {
11 DASSERT(screen != NULL);
12 eglDisplay_ = screen->eglDisplay();
13 screen_ = screen;
14@@ -58,7 +59,8 @@
15 attribs.append(EGL_NONE);
16 ASSERT(eglBindAPI(api_in_use()) == EGL_TRUE);
17 ASSERT((eglContext_ = eglCreateContext(
18- eglDisplay_, screen->eglConfig(), EGL_NO_CONTEXT, attribs.constData())) != EGL_NO_CONTEXT);
19+ eglDisplay_, screen->eglConfig(), share ? share->eglContext() : EGL_NO_CONTEXT,
20+ attribs.constData())) != EGL_NO_CONTEXT);
21
22 DLOG("QUbuntuBaseContext::QUbuntuBaseContext (this=%p, screen=%p)", this, screen);
23 }
24
25=== modified file 'src/platforms/base/context.h'
26--- src/platforms/base/context.h 2013-02-14 16:31:33 +0000
27+++ src/platforms/base/context.h 2014-03-18 16:39:15 +0000
28@@ -21,7 +21,8 @@
29
30 class QUbuntuBaseContext : public QPlatformOpenGLContext {
31 public:
32- QUbuntuBaseContext(QUbuntuBaseScreen* screen);
33+ QUbuntuBaseContext(QUbuntuBaseScreen* screen,
34+ QUbuntuBaseContext* share);
35 ~QUbuntuBaseContext();
36
37 // QPlatformOpenGLContext methods.
38
39=== modified file 'src/platforms/base/integration.cc'
40--- src/platforms/base/integration.cc 2013-11-06 12:44:39 +0000
41+++ src/platforms/base/integration.cc 2014-03-18 16:39:15 +0000
42@@ -88,7 +88,9 @@
43 QPlatformOpenGLContext* QUbuntuBaseIntegration::createPlatformOpenGLContext(
44 QOpenGLContext* context) {
45 DLOG("QUbuntuBaseIntegration::createPlatformOpenGLContext (this=%p, context=%p)", this, context);
46- return new QUbuntuBaseContext(static_cast<QUbuntuBaseScreen*>(context->screen()->handle()));
47+ return new QUbuntuBaseContext(
48+ static_cast<QUbuntuBaseScreen*>(context->screen()->handle()),
49+ static_cast<QUbuntuBaseContext*>(context->shareHandle()));
50 }
51
52 QStringList QUbuntuBaseIntegration::themeNames() const {

Subscribers

People subscribed via source and target branches