Merge lp:~chrisccoulson/libdbusmenu/signal-on-new-menu into lp:~ted/libdbusmenu/signal-on-new-menu

Proposed by Ted Gould
Status: Merged
Merged at revision: 187
Proposed branch: lp:~chrisccoulson/libdbusmenu/signal-on-new-menu
Merge into: lp:~ted/libdbusmenu/signal-on-new-menu
Diff against target: 39 lines (+8/-7)
1 file modified
libdbusmenu-glib/client.c (+8/-7)
To merge this branch: bzr merge lp:~chrisccoulson/libdbusmenu/signal-on-new-menu
Reviewer Review Type Date Requested Status
Ted Gould Approve
Review via email: mp+46770@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/client.c'
2--- libdbusmenu-glib/client.c 2011-01-13 15:53:15 +0000
3+++ libdbusmenu-glib/client.c 2011-01-19 15:09:54 +0000
4@@ -1538,6 +1538,14 @@
5 static void
6 update_layout_cb (GObject * proxy, GAsyncResult * res, gpointer data)
7 {
8+ DbusmenuClient * client = DBUSMENU_CLIENT(data);
9+ DbusmenuClientPrivate * priv = DBUSMENU_CLIENT_GET_PRIVATE(client);
10+
11+ if (priv->layoutcall != NULL) {
12+ g_object_unref(priv->layoutcall);
13+ priv->layoutcall = NULL;
14+ }
15+
16 GError * error = NULL;
17 GVariant * params = NULL;
18
19@@ -1554,9 +1562,6 @@
20 g_variant_get(params, "(us)", &rev, &xml);
21 g_variant_unref(params);
22
23- DbusmenuClient * client = DBUSMENU_CLIENT(data);
24- DbusmenuClientPrivate * priv = DBUSMENU_CLIENT_GET_PRIVATE(client);
25-
26 guint parseable = parse_layout(client, xml);
27 g_free(xml);
28
29@@ -1567,10 +1572,6 @@
30
31 priv->my_revision = rev;
32 /* g_debug("Root is now: 0x%X", (unsigned int)priv->root); */
33- if (priv->layoutcall != NULL) {
34- g_object_unref(priv->layoutcall);
35- priv->layoutcall = NULL;
36- }
37 #ifdef MASSIVEDEBUGGING
38 g_debug("Client signaling layout has changed.");
39 #endif

Subscribers

People subscribed via source and target branches

to all changes: