Merge lp:~chrisccoulson/libdbusmenu/set-cached-menuitem into lp:libdbusmenu/0.5
Status: | Merged |
---|---|
Merged at revision: | 258 |
Proposed branch: | lp:~chrisccoulson/libdbusmenu/set-cached-menuitem |
Merge into: | lp:libdbusmenu/0.5 |
Diff against target: |
22 lines (+5/-0) 1 file modified
libdbusmenu-gtk/parser.c (+5/-0) |
To merge this branch: | bzr merge lp:~chrisccoulson/libdbusmenu/set-cached-menuitem |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+52624@code.launchpad.net |
Description of the change
Whilst investigating bug 723463, I wrote a small Python test application which just rapidly added/removed menus from the menubar at random, and noticed that under most conditions, menus were not being removed from the menubar when being removed from the application.
Initially, it seemed this might be related to bug 723463, but after some more digging I realised this problem was actually occurring on the application side (I wasn't seeing menuitem_
Then, I realised that we never actually set CACHED_MENUITEM anywhere in the parser!
This branch fixes this. As a side-effect of this, calling dbusmenu_
Oh, this actually fixes bug 729128