lp:~chrisccoulson/libdbusmenu/lp723873

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:libdbusmenu/0.5 at revision 246

Ted Gould (community): Approve on 2011-03-01

Diff: 78 lines (+18/-24)

1 file modified

libdbusmenu-glib/menuitem.c (+18/-24)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #723873: indicator menu items missing since the recent natty update

High

Fix Released

Link a bug report

Related blueprints

242. By Chris Coulson on 2011-03-01

The last commit causes the warning in dbusmenu_menuitem_property_is_default to be thrown
when removing a property that has no default value. This warning seems bogus though, as any property that is not
in the menuitems local property list is a default value (as that is what dbusmenu_menuitem_property_get* will return).
Simplify this function to work like this and drop the warning

241. By Chris Coulson on 2011-02-28

Fix LP: #723873 - when a menuitems property is restored to a default value, the new
state is not updated correctly on the listening client. Make dbusmenu_menuitem_property_remove call
dbusmenu_menuitem_property_set_variant with a NULL value rather than manipulating the properties
directly. When removing a property that has a default value now, it will signal PROPERTY_CHANGED
with the default value, which means that changing a property from non-default to default over the
wire (which really just deletes the property) now works correctly. This is also now more aligned with
how dbusmenu_menuitem_property_get* works, which will return the default value for a property
after removing the property from the menuitem

240. By Ted Gould on 2011-02-26

Fixing to ensure we keep a variant reference.

239. By Ted Gould on 2011-02-24

0.3.99

238. By Ted Gould on 2011-02-24

Marking as having details available in the signal

237. By Ted Gould on 2011-02-24

Set property to status and return it

236. By Ted Gould on 2011-02-24

Changing the property changed handler to get the property instead of using accessor functions that might not be the same

235. By Ted Gould on 2011-02-24

Document the event signal define.

234. By Ted Gould on 2011-02-24

Adding in the event signal for the menuitem

233. By Ted Gould on 2011-02-24

Fixing signal emition to use the saved value instead of the enum