Merge lp:~chrisccoulson/libdbusmenu/lp722972-part-2 into lp:libdbusmenu/0.5
Proposed by
Chris Coulson
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ted Gould | ||||
Approved revision: | 269 | ||||
Merged at revision: | 269 | ||||
Proposed branch: | lp:~chrisccoulson/libdbusmenu/lp722972-part-2 | ||||
Merge into: | lp:libdbusmenu/0.5 | ||||
Diff against target: |
356 lines (+102/-39) 1 file modified
libdbusmenu-glib/client.c (+102/-39) |
||||
To merge this branch: | bzr merge lp:~chrisccoulson/libdbusmenu/lp722972-part-2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+53311@code.launchpad.net |
Description of the change
The g_variant_get_* family of calls which return a GVariant actually return reference counted, non-floating variant. Ensure that we always keep pointers to these so that we can properly unref them.
The same also applies to g_variant_
Also fix a couple of other minor leaks along the way. This fixes LP: #722972
To post a comment you must log in.
Wow, looks really good. Thanks!
review approve
merge approve