lp:~chrisccoulson/libdbusmenu/lp1011073

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:libdbusmenu/13.10 at revision 445

Ted Gould (community): Approve on 2013-05-29

PS Jenkins bot (community): Approve (continuous-integration) on 2013-05-28

Mathieu Trudel-Lapierre: Approve on 2013-05-17

Diff: 39 lines (+12/-3)

1 file modified

libdbusmenu-glib/menuitem.c (+12/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1011073: NetworkManager submenus sometimes unpopulated

Undecided

New

Link a bug report

Related blueprints

446. By Chris Coulson on 2013-05-28

Update for review comments

445. By Chris Coulson on 2013-05-17

Set the max ID of menuitems to G_MAXINT rather than 30000, as internally, the server side happily creates ID's greater than this which then wraparound on the client side.
We keep the minimum unchanged at -1, as some consumers addume that < 0 is an error (rather than -1). To make this a bit less fragile, handle rollover on the server side from G_MAXINT to 1, rather than having a signed integer overflow which will just break things a bit later on

444. By PS Jenkins bot on 2013-05-15

Releasing 12.10.3daily13.05.15-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

443. By Mathieu Trudel-Lapierre on 2013-05-15

Remove stray g_message().

Approved by PS Jenkins bot, Mathieu Trudel-Lapierre.

442. By Charles Kerr on 2013-05-15

In gtkclient's destructor, balance client's earlier gtk_widget_add_accelerator() calls with gtk_widget_remove_accelerator() calls. Fixes: https://bugs.launchpad.net/bugs/1173262.

Approved by Mathieu Trudel-Lapierre, PS Jenkins bot.

441. By PS Jenkins bot on 2013-02-01

Releasing 12.10.3daily13.02.01-0ubuntu1 to ubuntu.

Approved by .

440. By Chris Coulson on 2013-01-29

Fix multiple leaks due to improper use of g_variant_parse() (fixes bug 1104136). Fixes: https://bugs.launchpad.net/bugs/1104136.

Approved by Ted Gould, PS Jenkins bot.

439. By Chris Coulson on 2013-01-22

Fix a memory leak (bug 1103050). Fixes: https://bugs.launchpad.net/bugs/1103050.

Approved by Charles Kerr, PS Jenkins bot.

438. By Mathieu Trudel-Lapierre on 2013-01-21

Remove uses of g_type_init. Fixes: https://bugs.launchpad.net/bugs/1102468, https://bugs.launchpad.net/bugs/1102471.

Approved by PS Jenkins bot, Didier Roche.

437. By Didier Roche-Tolomelli on 2013-01-09

Add bootstrap message.

Approved by PS Jenkins bot.