Merge lp:~chrisccoulson/aptdaemon/fix-hang-after-simulate into lp:aptdaemon

Proposed by Chris Coulson
Status: Merged
Merged at revision: 755
Proposed branch: lp:~chrisccoulson/aptdaemon/fix-hang-after-simulate
Merge into: lp:aptdaemon
Diff against target: 12 lines (+1/-1)
1 file modified
aptdaemon/core.py (+1/-1)
To merge this branch: bzr merge lp:~chrisccoulson/aptdaemon/fix-hang-after-simulate
Reviewer Review Type Date Requested Status
Sebastian Heinlein Pending
Review via email: mp+85975@code.launchpad.net

Description of the change

After simulating a transaction, correctly disconnect from the "transaction-simulated" signal.

This was the cause of aptdaemon becoming unresponsive after indicator-session simulates an upgrade

To post a comment you must log in.
Revision history for this message
Sebastian Heinlein (glatzor) wrote :

Thanks a lot!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'aptdaemon/core.py'
2--- aptdaemon/core.py 2011-12-14 08:32:01 +0000
3+++ aptdaemon/core.py 2011-12-16 00:33:17 +0000
4@@ -997,7 +997,7 @@
5 def _on_transaction_simulated(self, worker, trans, deferred):
6 if trans is not self:
7 return
8- gobject.source_remove(self._simulated_cb)
9+ self.queue.worker.disconnect(self._simulated_cb)
10 self._simualted_cb = None
11 if trans.error:
12 deferred.errback(trans.error)

Subscribers

People subscribed via source and target branches

to status/vote changes: